Do not consider WMII as supporting _NET_ACTIVE_WINDOW

Do not consider the wmii window manager as supporting _NET_ACTIVE_WINDOW. In
particular, wmii indicates that it supports EWMH via _NET_SUPPORTING_WM_CHECK
and _NET_ACTIVE_WINDOW via _NET_SUPPORTED but does not ever set the
_NET_ACTIVE_WINDOW property. This is a known bug with wmii
(https://code.google.com/p/wmii/issues/detail?id=266)

BUG=417767
TEST=Manual, see bug

Committed: https://crrev.com/118b86758e6c1b7072a6dc9dcc1504f3fce1bf9b
Cr-Commit-Position: refs/heads/master@{#297313}

[pkotwicz, 2014-09-25 20:20:18]

pkotwicz@chromium.org changed reviewers:
+ sadrul@chromium.org

[pkotwicz, 2014-09-25 20:21:29]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2014-09-25 20:23:29]

Patchset #1 (id:20001) has been deleted

[pkotwicz, 2014-09-25 20:32:53]

Sadrul, PTAL

I have not dug into why it is possible to enter text in the web contents but not
the omnibox.

We are correctly checking whether _NET_ACTIVE_WINDOW is supported. GTK also
wrongly thinks that _NET_ACTIVE_WINDOW is supported.

The wmii bug seems to be known:
https://code.google.com/p/wmii/issues/detail?id=266

[sadrul, 2014-09-25 20:41:49]

https://codereview.chromium.org/602183003/diff/40001/ui/views/widget/desktop_...
File ui/views/widget/desktop_aura/x11_desktop_handler.cc (right):

https://codereview.chromium.org/602183003/diff/40001/ui/views/widget/desktop_...
ui/views/widget/desktop_aura/x11_desktop_handler.cc:66:
ui::GetXIDProperty(x_root_window_, "_NET_ACTIVE_WINDOW", &active_window);
What if chrome is the first app the user launches? Would a conformant WM set
_NET_ACTIVE_WINDOW on the root-window regardless of whether there is an
active-window or not?

[pkotwicz, 2014-09-25 21:35:30]

pkotwicz@chromium.org changed reviewers:
+ joleksy@opera.org

[pkotwicz, 2014-09-25 21:37:32]

It turns out that Cinnamon does not set _NET_ACTIVE_WINDOW on the root-window on
startup

This CL now effectively reverts https://codereview.chromium.org/549713003

We will need to do more investigation to find out why typing in the web contents
works but not in the omnibox.

[pkotwicz, 2014-09-25 21:42:15]

PS: joleksy@ If you can reproduce the problem that you mentioned in
https://codereview.chromium.org/549713003 I am very interested

[pkotwicz, 2014-09-26 17:43:01]

Sadrul, ping?

[sadrul, 2014-09-26 18:05:46]

The wmii issue is https://code.google.com/p/wmii/issues/detail?id=266

I wonder if we should use a blacklist instead

[pkotwicz, 2014-09-26 20:24:43]

Sadrul, can you please take another look? I have changed the CL to blacklist
wmii.

[sadrul, 2014-09-26 21:00:26]

sadrul@chromium.org changed reviewers:
+ derat@chromium.org

[sadrul, 2014-09-26 21:00:27]

+derat@

LGTM

[Daniel Erat, 2014-09-26 21:40:11]

lgtm (well, as good as a change to work around a busted window manager can look)

[pkotwicz, 2014-09-27 00:52:12]

pkotwicz@chromium.org changed reviewers:
+ sky@chromium.org

[pkotwicz, 2014-09-27 00:52:12]

sky@ for OWNERS

[pkotwicz, 2014-09-27 00:55:12]

sky@ for chrome/ OWNERS

[sky, 2014-09-29 17:11:15]

LGTM

[pkotwicz, 2014-09-29 17:50:55]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-09-29 17:51:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/602183003/80001

[commit-bot: I haz the power, 2014-09-29 18:01:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-29 18:01:03]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pkotwicz, 2014-09-29 21:35:25]

pkotwicz@chromium.org changed reviewers:
+ isherman@chromium.org

[pkotwicz, 2014-09-29 21:35:26]

isherman@ for tools/metrics OWNERS

[Ilya Sherman, 2014-09-29 21:52:30]

histograms.xml LGTM

[pkotwicz, 2014-09-29 23:59:31]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-09-30 00:00:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/602183003/80001

[commit-bot: I haz the power, 2014-09-30 00:06:42]

Committed patchset #3 (id:80001) as 28d462863a29576fe6e0e1933027b51c9c116272

[commit-bot: I haz the power, 2014-09-30 00:07:20]

Patchset 3 (id:??) landed as
https://crrev.com/118b86758e6c1b7072a6dc9dcc1504f3fce1bf9b
Cr-Commit-Position: refs/heads/master@{#297313}