Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 602133002: Disable accessibility when VoiceOver is turned off. (Closed)

Created:
6 years, 2 months ago by dmazzoni
Modified:
6 years, 2 months ago
CC:
chromium-reviews, creis+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nasko+codewatch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable accessibility when VoiceOver is turned off. (Depends on: https://codereview.chromium.org/606703003/) BUG=251382 Committed: https://crrev.com/82f6f9885248ba9ece56af554fe8a087b74bdf02 Cr-Commit-Position: refs/heads/master@{#300583}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -3 lines) Patch
M chrome/browser/chrome_browser_application_mac.mm View 1 chunk +8 lines, -3 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility_complete.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility_complete.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (10 generated)
dmazzoni
6 years, 2 months ago (2014-09-25 16:48:17 UTC) #2
pink (ping after 24hrs)
looks acceptible, but another mac person should make sure this is cool. Robert, please add ...
6 years, 2 months ago (2014-09-25 17:39:31 UTC) #4
Robert Sesek
I don't think we have any Mac a11y experts, but this is fine. LGTM.
6 years, 2 months ago (2014-09-25 18:02:09 UTC) #5
jam
lgtm
6 years, 2 months ago (2014-09-25 22:38:09 UTC) #6
aboxhall
Yay!
6 years, 2 months ago (2014-10-10 14:17:12 UTC) #8
dmazzoni
Dependent change is landed, let's try this one now.
6 years, 2 months ago (2014-10-13 07:43:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602133002/1
6 years, 2 months ago (2014-10-13 07:44:08 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/78266) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/17185) ios_dbg_simulator ...
6 years, 2 months ago (2014-10-13 07:46:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602133002/180001
6 years, 2 months ago (2014-10-21 18:57:20 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/81850) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/71475) android_aosp ...
6 years, 2 months ago (2014-10-21 19:02:41 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602133002/200001
6 years, 2 months ago (2014-10-21 20:15:01 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/27833)
6 years, 2 months ago (2014-10-21 21:50:20 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602133002/200001
6 years, 2 months ago (2014-10-21 21:54:54 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:200001)
6 years, 2 months ago (2014-10-22 00:39:28 UTC) #24
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 04:04:13 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/82f6f9885248ba9ece56af554fe8a087b74bdf02
Cr-Commit-Position: refs/heads/master@{#300583}

Powered by Google App Engine
This is Rietveld 408576698