Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 602093004: Fix component build after HyperlinkTextView move. (Closed)

Created:
6 years, 2 months ago by Avi (use Gerrit)
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, hashimoto
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix component build after HyperlinkTextView move. HyperlinkTextView moved components in 0e6cd43eb9a467c81382e37f686f3ebfdda5c1d3; this marks it as being exported for use in other components. BUG=402485 TEST=component build builds Committed: https://crrev.com/b930c8711443cd1f32f0834ba7ed454890824020 Cr-Commit-Position: refs/heads/master@{#296787}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ui/base/cocoa/controls/hyperlink_text_view.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Avi (use Gerrit)
6 years, 2 months ago (2014-09-25 19:24:11 UTC) #2
Robert Sesek
LGTM
6 years, 2 months ago (2014-09-25 19:24:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602093004/1
6 years, 2 months ago (2014-09-25 19:35:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 7142c5fb6074f754a276dbf04d5083d1a284ffca
6 years, 2 months ago (2014-09-25 20:47:51 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 20:48:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b930c8711443cd1f32f0834ba7ed454890824020
Cr-Commit-Position: refs/heads/master@{#296787}

Powered by Google App Engine
This is Rietveld 408576698