[ServiceWorker] Add was_fallback_required flag to ResourceResponseInfo. [1/2 blink]

[ServiceWorker] Add was_fallback_required flag to ResourceResponseInfo. [1/2 blink]

This flag is set when the request whose mode is CORS or CORS-with-forced-preflight is sent to a ServiceWorker but FetchEvent.respondWith is not called.
It is because the CORS preflight logic is implemented in the renderer.
So we can't simply fallback to the network in the browser process.

[1/2] blink: https://codereview.chromium.org/602073002/
[2/2] chromium: https://codereview.chromium.org/603913002/

BUG=416371, 408507
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182910

[horo, 2014-09-25 10:54:28]

horo@chromium.org changed reviewers:
+ yhirano@chromium.org

[horo, 2014-09-25 10:54:28]

yhirano@
Could you please review?

[yhirano, 2014-09-26 01:23:32]

https://codereview.chromium.org/602073002/diff/1/Source/platform/network/Reso...
File Source/platform/network/ResourceResponse.h (right):

https://codereview.chromium.org/602073002/diff/1/Source/platform/network/Reso...
Source/platform/network/ResourceResponse.h:265: bool m_wasFallbackRequired;
Isn't this name too generic? Suffixing with "ByServiceWorker" looks good.

https://codereview.chromium.org/602073002/diff/1/Source/platform/network/Reso...
Source/platform/network/ResourceResponse.h:315: bool m_wasFallbackRequired;
ditto

[horo, 2014-09-26 01:44:16]

https://codereview.chromium.org/602073002/diff/1/Source/platform/network/Reso...
File Source/platform/network/ResourceResponse.h (right):

https://codereview.chromium.org/602073002/diff/1/Source/platform/network/Reso...
Source/platform/network/ResourceResponse.h:265: bool m_wasFallbackRequired;
On 2014/09/26 01:23:32, yhirano wrote:
> Isn't this name too generic? Suffixing with "ByServiceWorker" looks good.

Done.

https://codereview.chromium.org/602073002/diff/1/Source/platform/network/Reso...
Source/platform/network/ResourceResponse.h:315: bool m_wasFallbackRequired;
On 2014/09/26 01:23:32, yhirano wrote:
> ditto

Done.

[yhirano, 2014-09-26 04:27:39]

"which mode is CORS" in the description should be "whose mode is CORS".

https://codereview.chromium.org/602073002/diff/20001/public/platform/WebURLRe...
File public/platform/WebURLResponse.h (right):

https://codereview.chromium.org/602073002/diff/20001/public/platform/WebURLRe...
public/platform/WebURLResponse.h:170: // Flag whether the fallback request with
skip service worker flag was required.
Please wrap the comment in 80 columns.

[horo, 2014-09-26 05:07:25]

done

https://codereview.chromium.org/602073002/diff/20001/public/platform/WebURLRe...
File public/platform/WebURLResponse.h (right):

https://codereview.chromium.org/602073002/diff/20001/public/platform/WebURLRe...
public/platform/WebURLResponse.h:170: // Flag whether the fallback request with
skip service worker flag was required.
On 2014/09/26 04:27:39, yhirano wrote:
> Please wrap the comment in 80 columns.

Done.

[yhirano, 2014-09-26 05:49:50]

lgtm

[horo, 2014-09-26 07:34:16]

horo@chromium.org changed reviewers:
+ jochen@chromium.org

[horo, 2014-09-26 07:34:16]

jochen@
Could you please review this?

[jochen (gone - plz use gerrit), 2014-09-29 12:59:01]

where is this flag used?

[horo, 2014-09-29 13:11:22]

On 2014/09/29 12:59:01, jochen wrote:
> where is this flag used?


I'm planing to use this flag in DocumentThreadableLoader::handleResponse() and
ResourceLoader::didReceiveResponse().
This is a work in progress patch.
https://codereview.chromium.org/600393004/

[jochen (gone - plz use gerrit), 2014-09-30 08:31:28]

lgtm

[horo, 2014-09-30 09:00:50]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2014-09-30 09:01:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/602073002/40001

[commit-bot: I haz the power, 2014-09-30 11:24:27]

Committed patchset #3 (id:40001) as 182910