Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 60203009: ComposedTreeWalker does't have to return a node if an insertion point has no distributed nodes. (Closed)

Created:
7 years, 1 month ago by hayato
Modified:
7 years, 1 month ago
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

ComposedTreeWalker does't have to return a node if an insertion point has no distributed nodes. A content insertion point never has child nodes if the insertion point has distributed nodes after r161137. A shadow insertion point may have child nodes even if the insertion point has no distributed nodes. We should return 0 in this case because child nodes of the shadow insertion point must not be treated as fallback elements after r161137. The relevant spec is: https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#distributions BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161596

Patch Set 1 #

Patch Set 2 : Fix compile warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M LayoutTests/fast/dom/shadow/composed-shadow-tree-walker.html View 1 chunk +10 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/composed-shadow-tree-walker-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
M Source/core/dom/shadow/ComposedTreeWalker.cpp View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
hayato
PTAL
7 years, 1 month ago (2013-11-06 10:29:14 UTC) #1
Hajime Morrita
lgtm. If there is relevant section in the spec, it would be great to have ...
7 years, 1 month ago (2013-11-07 04:37:25 UTC) #2
hayato
On 2013/11/07 04:37:25, morrita1 wrote: > lgtm. > If there is relevant section in the ...
7 years, 1 month ago (2013-11-07 05:31:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/60203009/1
7 years, 1 month ago (2013-11-07 05:32:32 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-11-07 06:03:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/60203009/140001
7 years, 1 month ago (2013-11-08 07:11:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/60203009/140001
7 years, 1 month ago (2013-11-08 08:07:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/60203009/140001
7 years, 1 month ago (2013-11-08 10:02:41 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-11-08 10:05:09 UTC) #9
Message was sent while issue was closed.
Change committed as 161596

Powered by Google App Engine
This is Rietveld 408576698