Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 60203003: Add support for empty parameter lists. (Closed)

Created:
7 years, 1 month ago by darin (slow to review)
Modified:
7 years, 1 month ago
CC:
chromium-reviews, Aaron Boodman, viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Add support for functions with 0 or 1 parameters. The parser just needs to always output an array for the list of parameters. BUG=315147 R=davemoore@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233036

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M mojo/public/bindings/parser/mojo_parser.py View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
davemoore (google)
lgtm
7 years, 1 month ago (2013-11-05 17:40:52 UTC) #1
darin (slow to review)
7 years, 1 month ago (2013-11-05 18:50:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r233036 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698