Issue 6020: Fixes a couple of bookmark bar bugs:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6020: Fixes a couple of bookmark bar bugs:... (Closed)

Created:
12 years, 2 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Glen Murphy

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixes a couple of bookmark bar bugs: . The folders on the bookmark bar now fade in like urls. . You can now middle click on folders to open all URLs. . If you attempt to open a folder with more than 15 urls we'll prompt before openning. BUG=242 529 1295385 TEST=middle click on a folder on the bookmark bar and make sure it opens all tabs in the background. Try this with a folder containing more than 15 bookmarks and make sure you get a message box before asking if you really want to open them all. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2756

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+161 lines, -54 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/bookmark_bar_context_menu_controller.h	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/bookmark_bar_context_menu_controller.cc	View	4 chunks	+72 lines, -34 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_drag_data.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/bookmark_bar_view.cc	View	7 chunks	+75 lines, -19 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Glen Murphy

12 years, 2 months ago (2008-09-30 23:58:56 UTC) #2

LGTM.

I'd prefer OpenAllImpl or similar to OpenAll0, but I just have an allergy to
numbers in function names, so do with it as you will.

Expand Messages | Collapse Messages