Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 601963002: [NaCl SDK]: nacl_io: add nacl_io_uninit function. (Closed)

Created:
6 years, 3 months ago by Sam Clegg
Modified:
6 years, 2 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_leak
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK]: nacl_io: add nacl_io_uninit function. Call this function on program shut down to allow nacl_io to free its resources. This fixes all the "potential" leak reported by valgrind --leak-check=full Committed: https://crrev.com/e3c6d9defedfec359fc3d7c69fd63fa36035e722 Cr-Commit-Position: refs/heads/master@{#296720}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M native_client_sdk/src/libraries/nacl_io/nacl_io.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/nacl_io.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi_simple/ps_main.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601963002/20001
6 years, 3 months ago (2014-09-25 01:22:06 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-25 01:22:10 UTC) #6
binji
lgtm
6 years, 2 months ago (2014-09-25 01:30:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601963002/20001
6 years, 2 months ago (2014-09-25 15:28:21 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 947cc0109fac6144a6463fbedfa353d05c5cb029
6 years, 2 months ago (2014-09-25 16:24:00 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 16:24:35 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e3c6d9defedfec359fc3d7c69fd63fa36035e722
Cr-Commit-Position: refs/heads/master@{#296720}

Powered by Google App Engine
This is Rietveld 408576698