Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 60193005: Don't add keep-alives for apps after the app keep-alive service has shut down. (Closed)

Created:
7 years, 1 month ago by Sam McNally
Modified:
7 years, 1 month ago
Reviewers:
benwells
CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Don't add keep-alives for apps after the app keep-alive service has shut down. BUG=314729 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233462

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M apps/app_keep_alive_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M apps/app_keep_alive_service.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M apps/app_keep_alive_service_unittest.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Sam McNally
7 years, 1 month ago (2013-11-06 01:39:57 UTC) #1
benwells
On 2013/11/06 01:39:57, Sam McNally wrote: lgtm. Should this service be doing anything on Mac?
7 years, 1 month ago (2013-11-06 06:06:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/60193005/1
7 years, 1 month ago (2013-11-06 06:19:25 UTC) #3
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=98461
7 years, 1 month ago (2013-11-06 08:52:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/60193005/1
7 years, 1 month ago (2013-11-06 09:34:07 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94782
7 years, 1 month ago (2013-11-06 13:01:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/60193005/1
7 years, 1 month ago (2013-11-06 20:33:52 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-06 20:57:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/60193005/1
7 years, 1 month ago (2013-11-06 22:49:08 UTC) #9
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 01:28:51 UTC) #10
Message was sent while issue was closed. 
Change committed as 233462

Powered by Google App Engine
This is Rietveld 408576698