Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 60193004: [Prerender] Avoid setting prerender requests for sync XHRs to IDLE priority (Closed)

Created:
7 years, 1 month ago by akalin
Modified:
7 years, 1 month ago
Reviewers:
jam, davidben
CC:
chromium-reviews, cbentzel
Visibility:
Public.

Description

[Prerender] Avoid setting prerender requests for sync XHRs to IDLE priority This triggered a DCHECK in https://codereview.chromium.org/51683002/ . BUG=166689 R=davidben@chromium.org, jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233305

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
akalin
+davidben for review I decided to instead let the requests go through and not set ...
7 years, 1 month ago (2013-11-06 00:30:13 UTC) #1
davidben
On 2013/11/06 00:30:13, akalin wrote: > +davidben for review > > I decided to instead ...
7 years, 1 month ago (2013-11-06 16:00:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/60193004/1
7 years, 1 month ago (2013-11-06 17:42:09 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=34786
7 years, 1 month ago (2013-11-06 18:01:14 UTC) #4
akalin
+jam for OWNERS
7 years, 1 month ago (2013-11-06 18:12:20 UTC) #5
jam
lgtm
7 years, 1 month ago (2013-11-06 18:36:18 UTC) #6
akalin
7 years, 1 month ago (2013-11-06 18:37:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r233305 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698