|
|
Revert 232766 "Refactor MediaStreamManager to never output real ..."
> Refactor MediaStreamManager to never output real device id. It now always output sourceId in the form of a HMAC.
> DeviceMessageFilter now don't need to create a source id.
> This also fix a bug that made the source ids useless unless you have called gum once.
> Note that the sourceIds are still just using the security origin as salt. Next step is to add a random number that is stored in the profile somehow.
>
> This cl also make sure all public APIs are asynchronous by making sure all requests are posted on the UI thread and handled later. Before this change - there were code paths that posted on the UI thread and others that did not that could potentially happen after a request was cancelled. This also make it easier to fail a request based on the input arguments.
>
> BUG= 269139
>
> Review URL: https://codereview.chromium.org/34393006
TBR=perkj@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232999
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+414 lines, -666 lines) |
Patch |
 |
M |
chrome/browser/policy/policy_browsertest.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/media/device_request_message_filter.h
|
View
|
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/media/device_request_message_filter.cc
|
View
|
|
3 chunks |
+20 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/media/device_request_message_filter_unittest.cc
|
View
|
|
3 chunks |
+48 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/media/media_stream_dispatcher_host.cc
|
View
|
|
1 chunk |
+6 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc
|
View
|
|
18 chunks |
+44 lines, -241 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/media/media_stream_manager.h
|
View
|
|
5 chunks |
+22 lines, -52 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/media/media_stream_manager.cc
|
View
|
|
30 chunks |
+236 lines, -342 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/media/media_stream_manager_unittest.cc
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/media/media_stream_provider.h
|
View
|
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/media/media_stream_ui_proxy.cc
|
View
|
|
1 chunk |
+2 lines, -6 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/media/media_stream_ui_proxy_unittest.cc
|
View
|
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/media/video_capture_host_unittest.cc
|
View
|
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
content/public/common/media_stream_request.h
|
View
|
|
2 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/public/common/media_stream_request.cc
|
View
|
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/media_stream_impl.cc
|
View
|
|
3 chunks |
+8 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/mock_media_stream_dispatcher.cc
|
View
|
|
3 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
media/audio/mock_audio_manager.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
media/audio/mock_audio_manager.cc
|
View
|
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|
Chromium Code Reviews
Issue
60193002:
Revert 232766 "Refactor MediaStreamManager to never output real ..." (Closed)
