Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Issue 601923005: Add libva generator. (Closed)

Created:
6 years, 2 months ago by Jun Mukai
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add libva generator. BUG=None R=cmasone@chromium.org TBR=jln@chromium.org TEST=comparing generated libva files between gyp and gn Committed: https://crrev.com/f7571f31090438a7f5474efcd1a72983b656e97b Cr-Commit-Position: refs/heads/master@{#297477}

Patch Set 1 #

Patch Set 2 : fix dependencies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1 line) Patch
M content/common/BUILD.gn View 1 2 chunks +35 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
Jun Mukai
6 years, 2 months ago (2014-09-30 00:42:10 UTC) #2
Chris Masone
The action definition looks fine to me GN-wise in content_common.gypi, though, the rule that does ...
6 years, 2 months ago (2014-09-30 01:02:44 UTC) #3
Jun Mukai
oops, haven't noticed that. Updated. note that "<(output_root)" won't be necessary in GN because of ...
6 years, 2 months ago (2014-09-30 02:30:22 UTC) #4
Chris Masone
lgtm
6 years, 2 months ago (2014-09-30 03:28:45 UTC) #5
Jun Mukai
let me go with TBR=jln because his status says he's slow right now, and this ...
6 years, 2 months ago (2014-09-30 18:07:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601923005/20001
6 years, 2 months ago (2014-09-30 18:09:07 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as b2f60d589fef217eda67b5e53cf717db57e5b01b
6 years, 2 months ago (2014-09-30 19:19:18 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 19:20:11 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f7571f31090438a7f5474efcd1a72983b656e97b
Cr-Commit-Position: refs/heads/master@{#297477}

Powered by Google App Engine
This is Rietveld 408576698