Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 601923003: Revert of PPAPI: Never re-enter JavaScript for PostMessage. (Closed)

Created:
6 years, 3 months ago by bbudge
Modified:
6 years, 3 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of PPAPI: Never re-enter JavaScript for PostMessage. (patchset #4 id:60001 of https://codereview.chromium.org/589213003/) Reason for revert: May be crashing Chrome: https://code.google.com/p/chromium/issues/detail?id=417511 Original issue's description: > PPAPI: Never re-enter JavaScript for PostMessage. > > Blocking renderer->plugin messages can be interrupted by any message > from the plugin->renderer (even async ones). So while handline a blocking > message, such as HandleInputEvent or HandleBlockingMessage, it's currently > possible to re-enter JavaScript. This patch makes that impossible by > queueing up Plugin->Renderer messages sent via PPB_Messaging::PostMessage > while any renderer->plugin sync message is on the stack. > > BUG=384528 > > Committed: https://crrev.com/f73075c99b5ba30e8d62dc5f13fdfb210d0fc506 > Cr-Commit-Position: refs/heads/master@{#296311} TBR=raymes@chromium.org,dmichael@chromium.org NOTREECHECKS=true NOTRY=true BUG=384528 Committed: https://crrev.com/50c6f1a0cf5d6a991f7005ba8c0e2d2a4a2f6f22 Cr-Commit-Position: refs/heads/master@{#296571}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -136 lines) Patch
M content/renderer/pepper/host_dispatcher_wrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/host_dispatcher_wrapper.cc View 3 chunks +2 lines, -9 lines 0 comments Download
M content/renderer/pepper/message_channel.h View 6 chunks +8 lines, -33 lines 0 comments Download
M content/renderer/pepper/message_channel.cc View 7 chunks +22 lines, -56 lines 0 comments Download
M content/renderer/pepper/pepper_hung_plugin_filter.h View 1 chunk +2 lines, -3 lines 0 comments Download
M ppapi/proxy/dispatcher.h View 2 chunks +2 lines, -3 lines 0 comments Download
M ppapi/proxy/dispatcher.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ppapi/proxy/host_dispatcher.h View 7 chunks +6 lines, -11 lines 0 comments Download
M ppapi/proxy/host_dispatcher.cc View 4 chunks +6 lines, -14 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.cc View 4 chunks +11 lines, -2 lines 0 comments Download
M ppapi/tests/test_message_handler.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
bbudge
Created Revert of PPAPI: Never re-enter JavaScript for PostMessage.
6 years, 3 months ago (2014-09-24 23:41:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601923003/1
6 years, 3 months ago (2014-09-24 23:42:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as b54d460a861730ad5c422f9533f82338a730738d
6 years, 3 months ago (2014-09-24 23:43:44 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 23:47:19 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50c6f1a0cf5d6a991f7005ba8c0e2d2a4a2f6f22
Cr-Commit-Position: refs/heads/master@{#296571}

Powered by Google App Engine
This is Rietveld 408576698