Issue 6019001: Make animation loop more understandable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6019001: Make animation loop more understandable. (Closed)

Created:
10 years ago by Luigi Semenzato

Modified:
9 years, 7 months ago

Reviewers:
Daniel Erat

CC:
chromium-os-reviews_chromium.org

Base URL:
http://git.chromium.org/git/ply-image.git@master

Visibility:
Public.

Description

Make animation loop more understandable. Change-Id: I71215e8f36abe82e591ec35880962628827a4b6f BUG=10292 TEST=ran the program Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=d5388df

Patch Set 1 #

Patch Set 2 : Small tweaks. #

Total comments: 1

Patch Set 3 : rename variables #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -37 lines)			Patch
	M	src/ply-image.c	View	1 2	3 chunks	+36 lines, -37 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Luigi Semenzato

I suspect we'll play with this some more, so I changed the animation loop based ...

10 years ago (2010-12-17 18:26:09 UTC) #1

Daniel Erat

10 years ago (2010-12-17 19:15:42 UTC) #2

LGTM

http://codereview.chromium.org/6019001/diff/2001/src/ply-image.c
File src/ply-image.c (right):

http://codereview.chromium.org/6019001/diff/2001/src/ply-image.c#newcode493
src/ply-image.c:493: int64_t timespec_to_nsec(struct timespec x)
nit: better variable names ('spec' instead of 'x', 'nsec' instead of 'y'?)

Expand Messages | Collapse Messages