Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(97)

Issue 6019001: Make animation loop more understandable. (Closed)

Created:
8 years, 8 months ago by Luigi Semenzato
Modified:
8 years, 3 months ago
Reviewers:
Daniel Erat
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Make animation loop more understandable. Change-Id: I71215e8f36abe82e591ec35880962628827a4b6f BUG=10292 TEST=ran the program Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=d5388df

Patch Set 1 #

Patch Set 2 : Small tweaks. #

Total comments: 1

Patch Set 3 : rename variables #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -37 lines) Patch
M src/ply-image.c View 1 2 3 chunks +36 lines, -37 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Luigi Semenzato
I suspect we'll play with this some more, so I changed the animation loop based ...
8 years, 8 months ago (2010-12-17 18:26:09 UTC) #1
Daniel Erat
8 years, 8 months ago (2010-12-17 19:15:42 UTC) #2
LGTM

http://codereview.chromium.org/6019001/diff/2001/src/ply-image.c
File src/ply-image.c (right):

http://codereview.chromium.org/6019001/diff/2001/src/ply-image.c#newcode493
src/ply-image.c:493: int64_t timespec_to_nsec(struct timespec x)
nit: better variable names ('spec' instead of 'x', 'nsec' instead of 'y'?)

Powered by Google App Engine
This is Rietveld 408576698