chrome/browser/extensions/api/networking_private/networking_private_api.cc - Issue 601893002: Fix crash in NetworkingPrivateGetEnabledNetworkTypesFunction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_api.cc

Issue 601893002: Fix crash in NetworkingPrivateGetEnabledNetworkTypesFunction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/networking_private/networking_private_api.cc

diff --git a/chrome/browser/extensions/api/networking_private/networking_private_api.cc b/chrome/browser/extensions/api/networking_private/networking_private_api.cc

index d698a0d22e4a9b9f409ef5aa656d8a7a2bc4d27f..89dfb3b73e016f272a77c80b0ed1047b674feeac 100644

--- a/chrome/browser/extensions/api/networking_private/networking_private_api.cc

+++ b/chrome/browser/extensions/api/networking_private/networking_private_api.cc

@@ -287,7 +287,7 @@ bool NetworkingPrivateGetEnabledNetworkTypesFunction::RunSync() {

error_ = networking_private::kErrorNotSupported;

return false;

}

- scoped_ptr<base::ListValue> enabled_networks_list;

+ scoped_ptr<base::ListValue> enabled_networks_list(new base::ListValue);

for (base::ListValue::iterator iter = enabled_networks_onc_types->begin();

iter != enabled_networks_onc_types->end(); ++iter) {

std::string type;

« no previous file with comments | « no previous file | no next file » | no next file with comments »