Improve cr_cronet.py - pass unknown options to test runner and debugger

Improve cr_cronet.py - pass unknown options to test runner and debugger.

For example "cr_cronet.py test -f *Quic*" will run just Quic tests.

BUG=

Committed: https://crrev.com/408b815de5e406a843075b78cdc33516ff13fd4e
Cr-Commit-Position: refs/heads/master@{#297304}

[mef, 2014-09-24 17:50:15]

mef@chromium.org changed reviewers:
+ mmenke@chromium.org, xunjieli@chromium.org

[xunjieli, 2014-09-25 17:54:36]

https://codereview.chromium.org/601863002/diff/1/components/cronet/tools/cr_c...
File components/cronet/tools/cr_cronet.py (right):

https://codereview.chromium.org/601863002/diff/1/components/cronet/tools/cr_c...
components/cronet/tools/cr_cronet.py:60: '--activity=.CronetTestActivity ' + \
From what I understand, adb_gdb script binds a gdb server to a running activity.
Currently once CronetTestActivity starts, there are no interactive elements (eg.
buttons), but just an empty screen. So there is no way to trigger a break point
if there is one. But I guess we can add something to the app later. So this
debug option is not very meaningful right now, right? If I miss anything, please
let me know. I'd really like to know how to better debug on cronet :)

[xunjieli, 2014-09-25 21:37:34]

https://codereview.chromium.org/601863002/diff/1/components/cronet/tools/cr_c...
File components/cronet/tools/cr_cronet.py (right):

https://codereview.chromium.org/601863002/diff/1/components/cronet/tools/cr_c...
components/cronet/tools/cr_cronet.py:50: return run
('build/android/adb_install_apk.py ' + release_arg + \
We probably don't want the release_arg here. Right now, it gives me "Abort
message: '[0925/173436:FATAL:jni_android.cc(158)] Check failed:
!ClearException(env) && clazz. Failed to find class
org/chromium/cronet_test_apk/MockUrlRequestJobTest". I am guessing that the
release_arg strips off that MockUrlRequestJobTest class that I have just added.

[chromium-reviews, 2014-09-25 21:55:31]

On Thu, Sep 25, 2014 at 5:37 PM, <xunjieli@chromium.org> wrote:

>
> https://codereview.chromium.org/601863002/diff/1/
> components/cronet/tools/cr_cronet.py
> File components/cronet/tools/cr_cronet.py (right):
>
> https://codereview.chromium.org/601863002/diff/1/
> components/cronet/tools/cr_cronet.py#newcode50
> components/cronet/tools/cr_cronet.py:50: return run
> ('build/android/adb_install_apk.py ' + release_arg + \
> We probably don't want the release_arg here. Right now, it gives me
> "Abort message: '[0925/173436:FATAL:jni_android.cc(158)] Check failed:
> !ClearException(env) && clazz. Failed to find class
> org/chromium/cronet_test_apk/MockUrlRequestJobTest". I am guessing that
> the release_arg strips off that MockUrlRequestJobTest class that I have
> just added.
>
> Sorry this is a different issue. Please ignore this comment. The crash is
because if I only build cronet_test_apk,  "jni/MockUrlRequestJobTest_jni.h"
wont be generated. I will fix that.


> https://codereview.chromium.org/601863002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[mef, 2014-09-29 15:58:30]

On 2014/09/25 21:55:31, chromium-reviews wrote:
> On Thu, Sep 25, 2014 at 5:37 PM, <mailto:xunjieli@chromium.org> wrote:
> 
> >
> > https://codereview.chromium.org/601863002/diff/1/
> > components/cronet/tools/cr_cronet.py
> > File components/cronet/tools/cr_cronet.py (right):
> >
> > https://codereview.chromium.org/601863002/diff/1/
> > components/cronet/tools/cr_cronet.py#newcode50
> > components/cronet/tools/cr_cronet.py:50: return run
> > ('build/android/adb_install_apk.py ' + release_arg + \
> > We probably don't want the release_arg here. Right now, it gives me
> > "Abort message: '[0925/173436:FATAL:jni_android.cc(158)] Check failed:
> > !ClearException(env) && clazz. Failed to find class
> > org/chromium/cronet_test_apk/MockUrlRequestJobTest". I am guessing that
> > the release_arg strips off that MockUrlRequestJobTest class that I have
> > just added.
> >
> > Sorry this is a different issue. Please ignore this comment. The crash is
> because if I only build cronet_test_apk,  "jni/MockUrlRequestJobTest_jni.h"
> wont be generated. I will fix that.
> 
> 
> > https://codereview.chromium.org/601863002/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

So, WDYT?

[xunjieli, 2014-09-29 16:03:05]

https://codereview.chromium.org/601863002/diff/1/components/cronet/tools/cr_c...
File components/cronet/tools/cr_cronet.py (right):

https://codereview.chromium.org/601863002/diff/1/components/cronet/tools/cr_c...
components/cronet/tools/cr_cronet.py:50: return run
('build/android/adb_install_apk.py ' + release_arg + \
Remove "release_arg"?

[mef, 2014-09-29 17:17:56]

https://codereview.chromium.org/601863002/diff/1/components/cronet/tools/cr_c...
File components/cronet/tools/cr_cronet.py (right):

https://codereview.chromium.org/601863002/diff/1/components/cronet/tools/cr_c...
components/cronet/tools/cr_cronet.py:50: return run
('build/android/adb_install_apk.py ' + release_arg + \
On 2014/09/29 16:03:04, xunjieli wrote:
> Remove "release_arg"?
> 

Why? I think it is useful to be able to build/install/test both release and
debug versions.

[xunjieli, 2014-09-29 17:37:42]

lgtm

https://codereview.chromium.org/601863002/diff/1/components/cronet/tools/cr_c...
File components/cronet/tools/cr_cronet.py (right):

https://codereview.chromium.org/601863002/diff/1/components/cronet/tools/cr_c...
components/cronet/tools/cr_cronet.py:50: return run
('build/android/adb_install_apk.py ' + release_arg + \
On 2014/09/29 17:17:56, mef wrote:
> On 2014/09/29 16:03:04, xunjieli wrote:
> > Remove "release_arg"?
> > 
> 
> Why? I think it is useful to be able to build/install/test both release and
> debug versions.

I see. I misunderstood the intention of this variable. It becomes clear after
reading the earlier code.

[mmenke, 2014-09-29 18:03:27]

LGTM.  Skimmed over the code, but I'm deferring to Helen on the particulars of
adb_gdb syntax.

[mef, 2014-09-29 22:49:02]

The CQ bit was checked by mef@chromium.org

[commit-bot: I haz the power, 2014-09-29 22:49:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/601863002/20001

[commit-bot: I haz the power, 2014-09-29 23:37:40]

Committed patchset #2 (id:20001) as ea6550c0dc1edb32348665713218398ee988fc26

[commit-bot: I haz the power, 2014-09-29 23:38:24]

Patchset 2 (id:??) landed as
https://crrev.com/408b815de5e406a843075b78cdc33516ff13fd4e
Cr-Commit-Position: refs/heads/master@{#297304}