Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 601843002: Merge web_request_api_utils back into web_request_api_helpers. (Closed)

Created:
6 years, 3 months ago by wjmaclean
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Xi Han, lfg, Fady Samuel
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Merge utils back into helpers. While moving web_request files, we created web_request_api_utils to allow moving the functionality of web_request_api_helpers a bit at a time. Everything has moved, so it's time to recombine. BUG=352293 Committed: https://crrev.com/9236b5422b6e7e9b3b6ffc10f10e93c4ac43e9b5 Cr-Commit-Position: refs/heads/master@{#296473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -131 lines) Patch
M extensions/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api.cc View 5 chunks +3 lines, -6 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api_helpers.h View 3 chunks +15 lines, -1 line 0 comments Download
M extensions/browser/api/web_request/web_request_api_helpers.cc View 4 chunks +69 lines, -0 lines 0 comments Download
D extensions/browser/api/web_request/web_request_api_utils.h View 1 chunk +0 lines, -34 lines 0 comments Download
D extensions/browser/api/web_request/web_request_api_utils.cc View 1 chunk +0 lines, -83 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
wjmaclean
Ken, ready for another easy one? :-)
6 years, 3 months ago (2014-09-24 17:23:39 UTC) #2
Ken Rockot(use gerrit already)
lgtm
6 years, 3 months ago (2014-09-24 17:24:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601843002/1
6 years, 3 months ago (2014-09-24 17:30:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as d8ef76611d5c1a27b2472a24fed2ae5387415190
6 years, 3 months ago (2014-09-24 18:29:37 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 18:30:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9236b5422b6e7e9b3b6ffc10f10e93c4ac43e9b5
Cr-Commit-Position: refs/heads/master@{#296473}

Powered by Google App Engine
This is Rietveld 408576698