Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 601823003: Roll src/breakpad/src a513e85:3518935 (svn 1384:1387) (Closed)

Created:
6 years, 2 months ago by Lei Zhang
Modified:
6 years, 2 months ago
Reviewers:
Nico
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll src/breakpad/src a513e85:3518935 (svn 1384:1387) r1385: Linux: Call memset() in a couple places in ExceptionHandler. r1386: IWYU in minidump_writer.cc to fix building with libc++. r1387: Fix some nits raised by Timur for r1385. Also remove Valgrind suppression Breakpad r1385 fixed. BUG=332335 Committed: https://crrev.com/33169d9f2497a79fdde3ae51c5aa7266032526c7 Cr-Commit-Position: refs/heads/master@{#296497}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
6 years, 2 months ago (2014-09-24 19:02:52 UTC) #2
Nico
lgtm
6 years, 2 months ago (2014-09-24 19:02:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601823003/1
6 years, 2 months ago (2014-09-24 19:05:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 42808bcc829fe2388d78db77eab59a4649c6399c
6 years, 2 months ago (2014-09-24 20:06:10 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-24 20:06:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33169d9f2497a79fdde3ae51c5aa7266032526c7
Cr-Commit-Position: refs/heads/master@{#296497}

Powered by Google App Engine
This is Rietveld 408576698