Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 601743002: Update device_management_backend.proto with pairing protocol. (Closed)

Created:
6 years, 2 months ago by achuithb
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update device_management_backend.proto with pairing protocol. This should reflect the changes in https://critique.corp.google.com/#review/72343582 BUG=416806 TEST=unit tests Committed: https://crrev.com/9482995a5fd8bf6e340b1ac391bac207ddfd1996 Cr-Commit-Position: refs/heads/master@{#296403}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -3 lines) Patch
M components/policy/proto/device_management_backend.proto View 5 chunks +104 lines, -3 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
achuithb
please take a look.
6 years, 2 months ago (2014-09-24 11:59:57 UTC) #2
Joao da Silva
lgtm https://codereview.chromium.org/601743002/diff/1/components/policy/proto/device_management_backend.proto File components/policy/proto/device_management_backend.proto (right): https://codereview.chromium.org/601743002/diff/1/components/policy/proto/device_management_backend.proto#newcode629 components/policy/proto/device_management_backend.proto:629: The other protos don't have an empty newline ...
6 years, 2 months ago (2014-09-24 12:39:56 UTC) #3
achuithb
thanks for the review! https://codereview.chromium.org/601743002/diff/1/components/policy/proto/device_management_backend.proto File components/policy/proto/device_management_backend.proto (right): https://codereview.chromium.org/601743002/diff/1/components/policy/proto/device_management_backend.proto#newcode629 components/policy/proto/device_management_backend.proto:629: On 2014/09/24 12:39:56, Joao da ...
6 years, 2 months ago (2014-09-24 12:46:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601743002/1
6 years, 2 months ago (2014-09-24 12:47:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8770872cc9c9c106725a8b6c6cfb433d6525ff90
6 years, 2 months ago (2014-09-24 13:25:35 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-24 13:26:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9482995a5fd8bf6e340b1ac391bac207ddfd1996
Cr-Commit-Position: refs/heads/master@{#296403}

Powered by Google App Engine
This is Rietveld 408576698