Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Issue 601733002: Rename component_resources.h to components_resources.h (Closed)

Created:
6 years, 2 months ago by hashimoto
Modified:
5 years, 4 months ago
CC:
benquan, browser-components-watch_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, jam, rouslan+autofillwatch_chromium.org, James Su, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename component_resources.h to components_resources.h So no need to remember the correct header name for one for string resources and one for image resources. BUG=416395 TBR=jochen@chromium.org for name fix under chrome Committed: https://crrev.com/cfb460f63f38f20639689ac59dfbcf88b9f57e90 Cr-Commit-Position: refs/heads/master@{#296673}

Patch Set 1 #

Patch Set 2 : output_name hack #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -41 lines) Patch
M athena/resources/athena_resources.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/search_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_repack_chrome_100_percent.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_repack_chrome_200_percent.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_repack_resources.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/translate/translate_script_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/browser/wallet/wallet_items.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/credit_card.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/credit_card_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/components_tests.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/core/distiller_page.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/core/url_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/core/viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/webui/dom_distiller_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/autocomplete_match.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/pdf/renderer/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/pdf/renderer/pdf_resource_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/resources/BUILD.gn View 1 2 chunks +9 lines, -5 lines 1 comment Download
M components/resources/components_resources.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M components/resources/components_scaled_resources.grd View 1 chunk +3 lines, -3 lines 0 comments Download
M components/translate/core/browser/translate_script.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (9 generated)
hashimoto
6 years, 2 months ago (2014-09-24 11:15:28 UTC) #2
blundell
lgtm
6 years, 2 months ago (2014-09-24 11:51:01 UTC) #3
hashimoto
TBRing jochen@chromium.org for name fix under chrome
6 years, 2 months ago (2014-09-24 13:01:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601733002/1
6 years, 2 months ago (2014-09-24 13:02:58 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/1752)
6 years, 2 months ago (2014-09-24 13:10:53 UTC) #9
tfarina
lgtm I noticed this too, but never had time to stop and fix this myself! ...
6 years, 2 months ago (2014-09-24 13:31:16 UTC) #11
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-09-24 20:04:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601733002/1
6 years, 2 months ago (2014-09-25 02:04:13 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/2112)
6 years, 2 months ago (2014-09-25 02:13:29 UTC) #16
hashimoto
Added output_name hacks to BUILD.gn to avoid GN errors. I'll remove these hacks after waiting ...
6 years, 2 months ago (2014-09-25 05:32:25 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601733002/20001
6 years, 2 months ago (2014-09-25 05:33:50 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 741148ca583472b0e403ed9f2f688d6403089b2a
6 years, 2 months ago (2014-09-25 06:59:08 UTC) #20
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/cfb460f63f38f20639689ac59dfbcf88b9f57e90 Cr-Commit-Position: refs/heads/master@{#296673}
6 years, 2 months ago (2014-09-25 06:59:45 UTC) #21
brettw
5 years, 4 months ago (2015-08-12 17:08:11 UTC) #23
Message was sent while issue was closed.
https://codereview.chromium.org/601733002/diff/20001/components/resources/BUI...
File components/resources/BUILD.gn (right):

https://codereview.chromium.org/601733002/diff/20001/components/resources/BUI...
components/resources/BUILD.gn:19: # TODO(hashimoto): Remove this line.
These aren't very useful TODOs. I just came across this and I have no idea what
should happen. Presumably there's a reason for these lines but it seems like I
should just delete them.

Please be sure that TODOs are understandable by future people reading the code
with no context. In this case, it should have said when/why they should be
deleted and give some understanding about why you didn't just do it yourself.

Powered by Google App Engine
This is Rietveld 408576698