Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 60173003: Draft: apps APIs in Pepper (Closed)

Created:
7 years, 1 month ago by yzshen1
Modified:
6 years, 7 months ago
Reviewers:
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, raymes+watch_chromium.org, yzshen+watch_chromium.org, chromium-apps-reviews_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Draft: apps APIs in Pepper BUG=None TEST=None

Patch Set 1 #

Patch Set 2 : Try to switch to use C struct as underlying storage of C++ objects, but had problems. #

Patch Set 3 : revert patch2; make sure things passed between browser and plugin use the same allocation/deallocat… #

Patch Set 4 : from_c_type_converter_dev impl; extensions.cc #

Patch Set 5 : stub thunk; can run extensions example (with failure outputs) #

Patch Set 6 : make to_c_type_converter more efficient #

Patch Set 7 : cleanup #

Patch Set 8 : some draft of C-struct-backed C++ objects #

Patch Set 9 : move some code into their own files #

Patch Set 10 : some more draft for to/from_c_type_converter #

Patch Set 11 : Add support of outputing array #

Patch Set 12 : alarms C++ API #

Patch Set 13 : Alarms testing code #

Patch Set 14 : split things into their own files #

Patch Set 15 : some cleanup #

Patch Set 16 : remove PP_ArrayOutput from array structs. #

Total comments: 2

Patch Set 17 : fix use-after-free in array_dev #

Patch Set 18 : #

Patch Set 19 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3010 lines, -313 lines) Patch
M chrome/browser/component_updater/ppapi_utils.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/pepper/plugin_module.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
A ppapi/api/dev/pp_array_structs_dev.idl View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +19 lines, -0 lines 0 comments Download
A ppapi/api/dev/pp_optional_structs_dev.idl View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +23 lines, -0 lines 0 comments Download
A ppapi/api/dev/ppb_alarms_dev.idl View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +179 lines, -0 lines 0 comments Download
A ppapi/api/dev/ppb_foobar_dev.idl View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +74 lines, -0 lines 0 comments Download
A ppapi/c/dev/pp_array_structs_dev.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +40 lines, -0 lines 0 comments Download
A ppapi/c/dev/pp_optional_structs_dev.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +46 lines, -0 lines 0 comments Download
A ppapi/c/dev/ppb_alarms_dev.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +208 lines, -0 lines 0 comments Download
A ppapi/c/dev/ppb_foobar_dev.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +106 lines, -0 lines 0 comments Download
M ppapi/c/pp_macros.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
A ppapi/cpp/dev/alarms_dev.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +140 lines, -0 lines 0 comments Download
A ppapi/cpp/dev/alarms_dev.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +284 lines, -0 lines 0 comments Download
A ppapi/cpp/dev/array_dev.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +259 lines, -0 lines 0 comments Download
A ppapi/cpp/dev/foobar_dev.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +149 lines, -0 lines 0 comments Download
A ppapi/cpp/dev/foobar_dev.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +212 lines, -0 lines 0 comments Download
A ppapi/cpp/dev/from_c_type_converter_dev.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +52 lines, -0 lines 0 comments Download
A ppapi/cpp/dev/may_own_ptr_dev.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +78 lines, -0 lines 0 comments Download
A ppapi/cpp/dev/optional_dev.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +173 lines, -0 lines 0 comments Download
A ppapi/cpp/dev/string_wrapper_dev.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +47 lines, -0 lines 0 comments Download
A ppapi/cpp/dev/string_wrapper_dev.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +74 lines, -0 lines 0 comments Download
A ppapi/cpp/dev/struct_wrapper_base_dev.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +76 lines, -0 lines 0 comments Download
A ppapi/cpp/dev/to_c_type_converter_dev.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +109 lines, -0 lines 0 comments Download
D ppapi/cpp/extensions/dev/alarms_dev.h View 1 chunk +0 lines, -117 lines 0 comments Download
D ppapi/cpp/extensions/dev/alarms_dev.cc View 1 chunk +0 lines, -179 lines 0 comments Download
A + ppapi/cpp/extensions/dev/alarms_dev_old.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/cpp/extensions/dev/alarms_dev_old.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/cpp/output_traits.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 3 chunks +52 lines, -8 lines 0 comments Download
A ppapi/examples/extensions/extensions.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +374 lines, -0 lines 0 comments Download
A + ppapi/examples/extensions/extensions.html View 1 2 3 4 1 chunk +2 lines, -3 lines 0 comments Download
M ppapi/generators/idl_c_header.py View 1 chunk +5 lines, -3 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 12 chunks +86 lines, -0 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/ppapi_sources.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 6 chunks +18 lines, -2 lines 0 comments Download
M ppapi/ppapi_tests.gypi View 1 chunk +10 lines, -0 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/tests/all_c_includes.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +4 lines, -0 lines 0 comments Download
M ppapi/tests/all_cpp_includes.h View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -0 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
A ppapi/thunk/ppb_alarms_dev_thunk.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +101 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sam McNally
https://codereview.chromium.org/60173003/diff/380001/ppapi/cpp/dev/array_dev.h File ppapi/cpp/dev/array_dev.h (right): https://codereview.chromium.org/60173003/diff/380001/ppapi/cpp/dev/array_dev.h#newcode111 ppapi/cpp/dev/array_dev.h:111: UpdateWrappers(); This is unsafe for wrappers with a destructor ...
7 years ago (2013-12-11 08:10:43 UTC) #1
yzshen1
https://codereview.chromium.org/60173003/diff/380001/ppapi/cpp/dev/array_dev.h File ppapi/cpp/dev/array_dev.h (right): https://codereview.chromium.org/60173003/diff/380001/ppapi/cpp/dev/array_dev.h#newcode111 ppapi/cpp/dev/array_dev.h:111: UpdateWrappers(); Good catch! Thanks! :) On 2013/12/11 08:10:43, Sam ...
7 years ago (2013-12-11 18:01:31 UTC) #2
yzshen1
7 years ago (2013-12-11 18:01:33 UTC) #3 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698