Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 601713002: [telemetry] Only run reference builds on desktop. (Closed)

Created:
6 years, 2 months ago by dtu
Modified:
6 years, 2 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[telemetry] Only run reference builds on desktop. Maintain a whitelist of which browsers it makes sense to compare with --browser=reference (doesn't include system) BUG=416705 TEST=None. TBR=tonyg NOTRY=True Committed: https://crrev.com/c81f0c984d7096e8d671645d08a1844f11ad6a19 Cr-Commit-Position: refs/heads/master@{#296373}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M tools/telemetry/telemetry/test_runner.py View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dtu
6 years, 2 months ago (2014-09-24 09:35:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601713002/1
6 years, 2 months ago (2014-09-24 09:36:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as b2d5fa84aff5ef51df53286ad33341cb17627adc
6 years, 2 months ago (2014-09-24 09:36:35 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c81f0c984d7096e8d671645d08a1844f11ad6a19 Cr-Commit-Position: refs/heads/master@{#296373}
6 years, 2 months ago (2014-09-24 09:37:14 UTC) #5
tonyg
6 years, 2 months ago (2014-09-24 16:12:31 UTC) #6
Message was sent while issue was closed.
Seems like it's a bug that we check out the linux reference build on the android
bots. Why don't we look into fixing up the DEPS file so that doesn't happen.
Then we can remove this logic and it simply won't find a reference build.

Powered by Google App Engine
This is Rietveld 408576698