Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 601643002: Use a distinct source parameter on gaia endpoints for the reconcilor. (Closed)

Created:
6 years, 3 months ago by Roger Tawa OOO till Jul 10th
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@uber
Project:
chromium
Visibility:
Public.

Description

Use a distinct source parameter on gaia endpoints for the reconcilor. BUG=416612 TBR=nyquist@chromium.org, pkasting@chromium.org, courage@chromium.org Tommy: TBR for signin_manager_android.cc Michael: TBR for gaia_web_auth_flow.cc Peter: TBR for auto_login_infobar_delegate.cc Committed: https://crrev.com/109cbe0720b5af78110095c63898c53ef7ab757f Cr-Commit-Position: refs/heads/master@{#297097}

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : Other places #

Patch Set 4 : rebased #

Patch Set 5 : rebased #

Patch Set 6 : rebased #

Total comments: 14

Patch Set 7 : Address review comments #

Total comments: 2

Patch Set 8 : Remove functions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -44 lines) Patch
M chrome/browser/android/signin/signin_manager_android.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/signin/account_reconcilor_unittest.cc View 1 2 3 4 5 6 7 17 chunks +20 lines, -13 lines 0 comments Download
M chrome/browser/ui/auto_login_infobar_delegate.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/signin/core/browser/account_reconcilor.cc View 1 2 3 3 chunks +5 lines, -7 lines 0 comments Download
M components/signin/core/browser/signin_manager.cc View 2 chunks +3 lines, -1 line 0 comments Download
M google_apis/gaia/fake_gaia.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.cc View 1 2 3 4 5 6 1 chunk +3 lines, -2 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher_unittest.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -2 lines 0 comments Download
M google_apis/gaia/gaia_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gaia/gaia_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gaia/gaia_urls.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -2 lines 0 comments Download
M google_apis/gaia/gaia_urls.cc View 1 2 3 4 5 6 7 4 chunks +18 lines, -8 lines 0 comments Download
M google_apis/gaia/merge_session_helper.h View 2 chunks +4 lines, -0 lines 0 comments Download
M google_apis/gaia/merge_session_helper.cc View 1 2 5 chunks +8 lines, -4 lines 0 comments Download
M google_apis/gaia/merge_session_helper_unittest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M google_apis/gaia/ubertoken_fetcher.h View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M google_apis/gaia/ubertoken_fetcher.cc View 1 2 3 4 5 6 2 chunks +3 lines, -1 line 0 comments Download
M google_apis/gaia/ubertoken_fetcher_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 23 (4 generated)
Roger Tawa OOO till Jul 10th
Hi Hui, Please take a look. This is to allow gaia to differentiate between requests ...
6 years, 2 months ago (2014-09-25 15:25:10 UTC) #2
Roger Tawa OOO till Jul 10th
Hi Mike, Can you please take a look? Thanks.
6 years, 2 months ago (2014-09-26 15:40:32 UTC) #4
Mike Lerman
https://codereview.chromium.org/601643002/diff/100001/chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc File chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc (right): https://codereview.chromium.org/601643002/diff/100001/chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc#newcode81 chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc:81: GaiaConstants::kChromeSource, Should this be a distinct constant like kChromeExtensionSource? ...
6 years, 2 months ago (2014-09-26 16:57:08 UTC) #5
guohui
lgtm % two minor questions below https://codereview.chromium.org/601643002/diff/100001/google_apis/gaia/gaia_auth_fetcher.cc File google_apis/gaia/gaia_auth_fetcher.cc (right): https://codereview.chromium.org/601643002/diff/100001/google_apis/gaia/gaia_auth_fetcher.cc#newcode178 google_apis/gaia/gaia_auth_fetcher.cc:178: std::string query = ...
6 years, 2 months ago (2014-09-26 17:36:02 UTC) #6
Roger Tawa OOO till Jul 10th
Thanks guys, changes uploaded. https://codereview.chromium.org/601643002/diff/100001/chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc File chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc (right): https://codereview.chromium.org/601643002/diff/100001/chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc#newcode81 chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc:81: GaiaConstants::kChromeSource, On 2014/09/26 16:57:07, Mike ...
6 years, 2 months ago (2014-09-26 19:42:39 UTC) #7
Mike Lerman
https://codereview.chromium.org/601643002/diff/100001/google_apis/gaia/gaia_auth_fetcher.cc File google_apis/gaia/gaia_auth_fetcher.cc (right): https://codereview.chromium.org/601643002/diff/100001/google_apis/gaia/gaia_auth_fetcher.cc#newcode181 google_apis/gaia/gaia_auth_fetcher.cc:181: query.c_str())); On 2014/09/26 19:42:39, Roger Tawa wrote: > On ...
6 years, 2 months ago (2014-09-26 20:18:11 UTC) #8
Mike Lerman
lgtm
6 years, 2 months ago (2014-09-26 20:34:44 UTC) #9
Roger Tawa OOO till Jul 10th
https://codereview.chromium.org/601643002/diff/100001/google_apis/gaia/gaia_auth_fetcher.cc File google_apis/gaia/gaia_auth_fetcher.cc (right): https://codereview.chromium.org/601643002/diff/100001/google_apis/gaia/gaia_auth_fetcher.cc#newcode181 google_apis/gaia/gaia_auth_fetcher.cc:181: query.c_str())); On 2014/09/26 20:18:10, Mike Lerman wrote: > On ...
6 years, 2 months ago (2014-09-27 00:30:27 UTC) #10
Mike Lerman
Still lgtm
6 years, 2 months ago (2014-09-27 01:00:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601643002/140001
6 years, 2 months ago (2014-09-27 02:18:46 UTC) #14
nyquist
chrome/browser/android lgtm
6 years, 2 months ago (2014-09-27 02:28:23 UTC) #15
commit-bot: I haz the power
Committed patchset #8 (id:140001) as a9e4d3dd702681c0f124d24e07abf1b00a9a2107
6 years, 2 months ago (2014-09-27 02:43:30 UTC) #16
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/109cbe0720b5af78110095c63898c53ef7ab757f Cr-Commit-Position: refs/heads/master@{#297097}
6 years, 2 months ago (2014-09-27 02:44:30 UTC) #17
Michael Courage
On 2014/09/27 02:44:30, I haz the power (commit-bot) wrote: > Patchset 8 (id:??) landed as ...
6 years, 2 months ago (2014-09-29 17:36:00 UTC) #18
Peter Kasting
I'm included as a reviewer on this, but there was never a message indicating what ...
6 years, 2 months ago (2014-09-29 17:42:51 UTC) #19
nyquist
On 2014/09/29 17:42:51, Peter Kasting wrote: > I'm included as a reviewer on this, but ...
6 years, 2 months ago (2014-09-29 17:44:07 UTC) #20
Peter Kasting
On 2014/09/29 17:44:07, nyquist wrote: > On 2014/09/29 17:42:51, Peter Kasting wrote: > > I'm ...
6 years, 2 months ago (2014-09-29 17:45:49 UTC) #21
Peter Kasting
On 2014/09/29 17:44:07, nyquist wrote: > On 2014/09/29 17:42:51, Peter Kasting wrote: > > I'm ...
6 years, 2 months ago (2014-09-29 17:45:50 UTC) #22
Peter Kasting
6 years, 2 months ago (2014-09-29 17:46:14 UTC) #23
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698