Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: Source/core/html/HTMLInputElement.cpp

Issue 601633004: Revert "Revert of Fix update of validity cache value, so that it reflects the correct state of any … (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 430 matching lines...) Expand 10 before | Expand all | Expand 10 after
441 AtomicString valueString = fastGetAttribute(valueAttr); 441 AtomicString valueString = fastGetAttribute(valueAttr);
442 m_inputType->warnIfValueIsInvalid(valueString); 442 m_inputType->warnIfValueIsInvalid(valueString);
443 m_valueIfDirty = sanitizeValue(valueString); 443 m_valueIfDirty = sanitizeValue(valueString);
444 } else { 444 } else {
445 if (!hasDirtyValue()) 445 if (!hasDirtyValue())
446 m_inputType->warnIfValueIsInvalid(fastGetAttribute(valueAttr).string ()); 446 m_inputType->warnIfValueIsInvalid(fastGetAttribute(valueAttr).string ());
447 updateValueIfNeeded(); 447 updateValueIfNeeded();
448 } 448 }
449 449
450 m_needsToUpdateViewValue = true; 450 m_needsToUpdateViewValue = true;
451 setNeedsValidityCheck();
451 m_inputTypeView->updateView(); 452 m_inputTypeView->updateView();
452 453
453 if (didRespectHeightAndWidth != m_inputType->shouldRespectHeightAndWidthAttr ibutes()) { 454 if (didRespectHeightAndWidth != m_inputType->shouldRespectHeightAndWidthAttr ibutes()) {
454 ASSERT(elementData()); 455 ASSERT(elementData());
455 AttributeCollection attributes = attributesWithoutUpdate(); 456 AttributeCollection attributes = attributesWithoutUpdate();
456 if (const Attribute* height = attributes.find(heightAttr)) 457 if (const Attribute* height = attributes.find(heightAttr))
457 attributeChanged(heightAttr, height->value()); 458 attributeChanged(heightAttr, height->value());
458 if (const Attribute* width = attributes.find(widthAttr)) 459 if (const Attribute* width = attributes.find(widthAttr))
459 attributeChanged(widthAttr, width->value()); 460 attributeChanged(widthAttr, width->value());
460 if (const Attribute* align = attributes.find(alignAttr)) 461 if (const Attribute* align = attributes.find(alignAttr))
461 attributeChanged(alignAttr, align->value()); 462 attributeChanged(alignAttr, align->value());
462 } 463 }
463 464
464 if (document().focusedElement() == this) 465 if (document().focusedElement() == this)
465 document().updateFocusAppearanceSoon(true /* restore selection */); 466 document().updateFocusAppearanceSoon(true /* restore selection */);
466 467
467 setChangedSinceLastFormControlChangeEvent(false); 468 setChangedSinceLastFormControlChangeEvent(false);
468 469
469 addToRadioButtonGroup(); 470 addToRadioButtonGroup();
470 471
471 setNeedsValidityCheck();
472 notifyFormStateChanged(); 472 notifyFormStateChanged();
473 } 473 }
474 474
475 void HTMLInputElement::subtreeHasChanged() 475 void HTMLInputElement::subtreeHasChanged()
476 { 476 {
477 m_inputTypeView->subtreeHasChanged(); 477 m_inputTypeView->subtreeHasChanged();
478 // When typing in an input field, childrenChanged is not called, so we need to force the directionality check. 478 // When typing in an input field, childrenChanged is not called, so we need to force the directionality check.
479 calculateAndAdjustDirectionality(); 479 calculateAndAdjustDirectionality();
480 } 480 }
481 481
(...skipping 1322 matching lines...) Expand 10 before | Expand all | Expand 10 after
1804 { 1804 {
1805 listAttributeTargetChanged(); 1805 listAttributeTargetChanged();
1806 } 1806 }
1807 1807
1808 AXObject* HTMLInputElement::popupRootAXObject() 1808 AXObject* HTMLInputElement::popupRootAXObject()
1809 { 1809 {
1810 return m_inputTypeView->popupRootAXObject(); 1810 return m_inputTypeView->popupRootAXObject();
1811 } 1811 }
1812 1812
1813 } // namespace 1813 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698