Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 601593002: Fix MSVC warnings in prtime.cc about potential value truncation by inserting (Closed)

Created:
6 years, 3 months ago by Peter Kasting
Modified:
6 years, 3 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix MSVC warnings in prtime.cc about potential value truncation by inserting explicit casts. I didn't check whether there were other, better fixes here by changing more underlying types/behaviors; I assumed the existing code was correct and just made the typecasts explicit. BUG=81439 TEST=none Committed: https://crrev.com/9883dd4a348cf1e23e4e123b59daf2e2b14a3391 Cr-Commit-Position: refs/heads/master@{#296668}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M base/third_party/nspr/prtime.cc View 6 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Peter Kasting
6 years, 3 months ago (2014-09-23 23:52:15 UTC) #2
Ryan Sleevi
lgtm
6 years, 3 months ago (2014-09-23 23:58:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601593002/1
6 years, 3 months ago (2014-09-25 06:03:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 832d1851d5d8b40b0937ae15d48743ecc585b79d
6 years, 3 months ago (2014-09-25 06:34:26 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-25 06:35:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9883dd4a348cf1e23e4e123b59daf2e2b14a3391
Cr-Commit-Position: refs/heads/master@{#296668}

Powered by Google App Engine
This is Rietveld 408576698