Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 601573002: Add UMA stats for new Print Preview UI elements. (Closed)

Created:
6 years, 3 months ago by Aleksey Shlyapnikov
Modified:
6 years, 3 months ago
CC:
chromium-reviews, arv+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add UMA stats for new Print Preview UI elements. BUG=397741 Committed: https://crrev.com/d6a8369bbd241f7e6179f3c6a94728f8f985cdbd Cr-Commit-Position: refs/heads/master@{#296552}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add INVITATION_AVAILABLE UMA stat. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -3 lines) Patch
M chrome/browser/resources/print_preview/metrics.js View 1 2 chunks +16 lines, -2 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.js View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/search/destination_search.js View 1 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/settings/more_settings.js View 3 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 5 chunks +36 lines, -1 line 0 comments Download
M printing/print_job_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M printing/print_job_constants.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Aleksey Shlyapnikov
asvitkine: for histograms.xml
6 years, 3 months ago (2014-09-23 22:59:46 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm https://codereview.chromium.org/601573002/diff/1/chrome/browser/resources/print_preview/metrics.js File chrome/browser/resources/print_preview/metrics.js (right): https://codereview.chromium.org/601573002/diff/1/chrome/browser/resources/print_preview/metrics.js#newcode47 chrome/browser/resources/print_preview/metrics.js:47: INVITATION_ACCEPTED: 11, probably you also need INVITATION_AVAILIBLE counter.
6 years, 3 months ago (2014-09-23 23:46:37 UTC) #3
Aleksey Shlyapnikov
https://codereview.chromium.org/601573002/diff/1/chrome/browser/resources/print_preview/metrics.js File chrome/browser/resources/print_preview/metrics.js (right): https://codereview.chromium.org/601573002/diff/1/chrome/browser/resources/print_preview/metrics.js#newcode47 chrome/browser/resources/print_preview/metrics.js:47: INVITATION_ACCEPTED: 11, On 2014/09/23 23:46:36, Vitaly Buka wrote: > ...
6 years, 3 months ago (2014-09-24 00:43:14 UTC) #4
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 3 months ago (2014-09-24 00:45:06 UTC) #5
Alexei Svitkine (slow)
lgtm
6 years, 3 months ago (2014-09-24 14:46:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601573002/20001
6 years, 3 months ago (2014-09-24 17:31:20 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 4ef4d1ca5f98dd15e8bad1a6c5834433ce4fa0a0
6 years, 3 months ago (2014-09-24 23:01:38 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 23:02:29 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d6a8369bbd241f7e6179f3c6a94728f8f985cdbd
Cr-Commit-Position: refs/heads/master@{#296552}

Powered by Google App Engine
This is Rietveld 408576698