Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Issue 601553005: Adding webview tests to app_shell_browsertests. (Closed)

Created:
6 years, 2 months ago by lfg
Modified:
6 years, 2 months ago
Reviewers:
Yoyo Zhou, lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding webview tests to app_shell_browsertests. Tests added in this CL: TestLoadAbortChromeExtensionURLWrongPartition TestLoadAbortIllegalChromeURL TestLoadAbortIllegalFileURL TestLoadAbortIllegalJavaScriptURL TestLoadAbortInvalidNavigation TestLoadAbortNonWebSafeScheme TestLoadProgressEvent BUG=352293 Committed: https://crrev.com/e65fb36c46e761ffb1e8fd09008619d133995f61 Cr-Commit-Position: refs/heads/master@{#297298}

Patch Set 1 #

Patch Set 2 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -0 lines) Patch
M extensions/browser/guest_view/web_view/web_view_apitest.cc View 1 1 chunk +30 lines, -0 lines 0 comments Download
A + extensions/test/data/web_view/apitest/guest.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M extensions/test/data/web_view/apitest/main.js View 1 2 chunks +114 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
lfg
6 years, 2 months ago (2014-09-29 20:56:20 UTC) #2
lazyboy
lgtm
6 years, 2 months ago (2014-09-29 21:38:49 UTC) #3
lfg
6 years, 2 months ago (2014-09-29 21:42:11 UTC) #5
Yoyo Zhou
also LGTM
6 years, 2 months ago (2014-09-29 21:55:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601553005/20001
6 years, 2 months ago (2014-09-29 22:57:05 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as e50c2fdda0dfce059fa09858a44552a2bd1fb934
6 years, 2 months ago (2014-09-29 23:18:04 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 23:19:03 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e65fb36c46e761ffb1e8fd09008619d133995f61
Cr-Commit-Position: refs/heads/master@{#297298}

Powered by Google App Engine
This is Rietveld 408576698