Refactor FakeAttachmentStore

sync/internal_api/attachments/attachment_service_impl_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/internal_api/public/attachments/attachment_service_impl.h"
 
 #include "base/bind.h"
 #include "base/memory/weak_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/timer/mock_timer.h"
 #include "sync/internal_api/public/attachments/fake_attachment_downloader.h"
 #include "sync/internal_api/public/attachments/fake_attachment_uploader.h"
 #include "testing/gmock/include/gmock/gmock-matchers.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace syncer {
 
+namespace {
+
 class MockAttachmentStore : public AttachmentStore,
                             public base::SupportsWeakPtr<MockAttachmentStore> {
  public:
   MockAttachmentStore() {}
 
   virtual void Read(const AttachmentIdList& ids,
                     const ReadCallback& callback) OVERRIDE {
     read_ids.push_back(ids);
     read_callbacks.push_back(callback);
   }
@@ skipping 114 matching lines @@
     base::MessageLoop::current()->PostTask(
         FROM_HERE, base::Bind(upload_requests[id], result, id));
     upload_requests.erase(id);
   }
 
   std::map<AttachmentId, UploadCallback> upload_requests;
 
   DISALLOW_COPY_AND_ASSIGN(MockAttachmentUploader);
 };
 
+}  // namespace
 class AttachmentServiceImplTest : public testing::Test,

[maniscalco, 2014/09/30 00:26:13]

nit: new line above?

[pavely, 2014/09/30 00:30:38]

Done.

                                   public AttachmentService::Delegate {
  protected:
   AttachmentServiceImplTest() {}
 
   virtual void SetUp() OVERRIDE {
     network_change_notifier_.reset(net::NetworkChangeNotifier::CreateMock());
     InitializeAttachmentService(make_scoped_ptr(new MockAttachmentUploader()),
                                 make_scoped_ptr(new MockAttachmentDownloader()),
                                 this);
   }
@@ skipping 381 matching lines @@
   net::NetworkChangeNotifier::NotifyObserversOfNetworkChangeForTests(
       net::NetworkChangeNotifier::CONNECTION_WIFI);
   RunLoop();
 
   // No longer in backoff.
   ASSERT_TRUE(mock_timer()->IsRunning());
   ASSERT_EQ(base::TimeDelta(), mock_timer()->GetCurrentDelay());
 }
 
 }  // namespace syncer