Refactor FakeAttachmentStore

sync/api/attachments/attachment_store.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SYNC_API_ATTACHMENTS_ATTACHMENT_STORE_H_
 #define SYNC_API_ATTACHMENTS_ATTACHMENT_STORE_H_
 
 #include "base/callback.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "sync/api/attachments/attachment.h"
 #include "sync/api/attachments/attachment_id.h"
 #include "sync/base/sync_export.h"
 
 namespace base {
 class RefCountedMemory;
 }  // namespace base
 
 namespace syncer {
 
 class Attachment;
 class AttachmentId;
 
 // A place to locally store and access Attachments.
 //
 // Destroying this object does not necessarily cancel outstanding async
 // operations. If you need cancel like semantics, use WeakPtr in the callbacks.
-class SYNC_EXPORT AttachmentStore : public base::RefCounted<AttachmentStore> {
+class SYNC_EXPORT AttachmentStoreBase {

[maniscalco, 2014/09/29 20:57:52]

Can/should ASB be made SYNC_PRIVATE?

[pavely, 2014/09/29 23:27:08]

It is base class for AttachmentStore which should be accessible from
tests/consumers, I don't think it should be SYNC_EXPORT_PRIVATE.
On 2014/09/29 20:57:52, maniscalco wrote:

[maniscalco, 2014/09/30 00:26:13]

You're right, I agree.

  public:
-  AttachmentStore();
-
   // TODO(maniscalco): Consider udpating Read and Write methods to support
   // resumable transfers (bug 353292).
 
   enum Result {
     SUCCESS,            // No error, all completed successfully.
     UNSPECIFIED_ERROR,  // An unspecified error occurred for one or more items.
   };
 
   typedef base::Callback<void(const Result&,
                               scoped_ptr<AttachmentMap>,
                               scoped_ptr<AttachmentIdList>)> ReadCallback;
   typedef base::Callback<void(const Result&)> WriteCallback;
   typedef base::Callback<void(const Result&)> DropCallback;
 
+  AttachmentStoreBase();
+  virtual ~AttachmentStoreBase();
+
   // Asynchronously reads the attachments identified by |ids|.
   //
   // |callback| will be invoked when finished. AttachmentStore will attempt to
   // read all attachments specified in ids. If any of the attachments do not
   // exist or could not be read, |callback|'s Result will be UNSPECIFIED_ERROR.
   // Callback's AttachmentMap will contain all attachments that were
   // successfully read, AttachmentIdList will contain attachment ids of
   // attachments that are unavailable in attachment store, these need to be
   // downloaded from server.
   //
@@ skipping 18 matching lines @@
   //
   // This does not remove attachments from the server.
   //
   // |callback| will be invoked when finished. Attempting to drop an attachment
   // that does not exist is not an error. If any of the existing attachment
   // could not be dropped, |callback|'s Result will be UNSPECIFIED_ERROR. When
   // this happens, some or none of the attachments may have been dropped
   // successfully.
   virtual void Drop(const AttachmentIdList& ids,
                     const DropCallback& callback) = 0;
+};
+
+// AttachmentStore is an interface exposed to device type and AttachmentService

[maniscalco, 2014/09/29 20:57:52]

s/device/data/

[pavely, 2014/09/29 23:27:07]

Done.

+// code. Also contains factory methods for default implementations.
+class SYNC_EXPORT AttachmentStore : public AttachmentStoreBase,
+                                    public base::RefCounted<AttachmentStore> {

[maniscalco, 2014/09/29 20:57:52]

I would be inclined to use RefCountedThreadSafe (here and elsewhere) instead of
just RC.  Here's my thinking.  Given how this type is used, the cost of mutexes
or atomic inc/dec in AddRef/Release is negligible.  I *think* RC might be good
enough for our uses, but there's a fair chance we may need to use RCTS in the
future and it would be easy to forget to upgrade from RC to RCTS.

[pavely, 2014/09/29 23:27:07]

Done.

+ public:
+  AttachmentStore();
+
+  // Creates an AttachmentStoreProxy backed by in-memory implementation of
+  // attachment store. For now frontend lives on the same thread as backend.
+  static scoped_refptr<AttachmentStore> CreateInMemoryStore();
 
  protected:
   friend class base::RefCounted<AttachmentStore>;
   virtual ~AttachmentStore();
 };
 
 }  // namespace syncer
 
 #endif  // SYNC_API_ATTACHMENTS_ATTACHMENT_STORE_H_