LayoutTests/fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document.html - Issue 60153008: Remove TreatNullAs=NullString for <base>, <body> and <br>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document.html

Issue 60153008: Remove TreatNullAs=NullString for <base>, <body> and <br> (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix test Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | LayoutTests/fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document.html

diff --git a/LayoutTests/fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document.html b/LayoutTests/fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document.html

index 7bf054c22e50f2ecb61108cab5cde4bcf82f4f3c..5739008dc273538074c85c7842ed26d7ed338f43 100644

--- a/LayoutTests/fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document.html

+++ b/LayoutTests/fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document.html

@@ -23,8 +23,7 @@ shouldBeTrue("endsWith(document.querySelector('base').href, 'foo/bar/')");

shouldBeFalse("endsWith(document.querySelector('base').href, 'foo/bar/foo/bar/')");

base.href = null;

-shouldBeFalse("document.querySelector('base').hasAttribute('href')");

-shouldBeTrue("endsWith(document.querySelector('base').href, '/href-attribute-resolves-with-respect-to-document.html')");

+shouldBeTrue("endsWith(document.querySelector('base').href, '/null')");

// When a document does not have a URL, base cannot be resolved

@@ -54,4 +53,4 @@ newWindow.close();

finishJSTest();

-</script>

+</script>

« no previous file with comments | « no previous file | LayoutTests/fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document-expected.txt » ('j') | no next file with comments »