Move KeyboardCodes to platform/

Move KeyboardCodes to platform/

BUG=297477
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163967

[abarth-chromium, 2013-11-05 16:05:57]

lgtm

https://codereview.chromium.org/60153002/diff/1/Source/web/WebInputEvent.cpp
File Source/web/WebInputEvent.cpp (right):

https://codereview.chromium.org/60153002/diff/1/Source/web/WebInputEvent.cpp#...
Source/web/WebInputEvent.cpp:33: #include "platform/KeyboardCodes.h"
We should have a blank line above this line.  The general format is:

config.h
<primary header>
<blank line>
<all the rest of the headers in alphabetical order>

[pilgrim_google, 2013-11-05 16:55:24]

On 2013/11/05 16:05:57, abarth wrote:
> lgtm
> 
> https://codereview.chromium.org/60153002/diff/1/Source/web/WebInputEvent.cpp
> File Source/web/WebInputEvent.cpp (right):
> 
>
https://codereview.chromium.org/60153002/diff/1/Source/web/WebInputEvent.cpp#...
> Source/web/WebInputEvent.cpp:33: #include "platform/KeyboardCodes.h"
> We should have a blank line above this line.  The general format is:
> 
> config.h
> <primary header>
> <blank line>
> <all the rest of the headers in alphabetical order>

OK.

Also, why is this failing on android-rel? 

FAILED: /mnt/scratch0/b_used/build/goma/gomacc
/mnt/scratch0/b_used/build/slave/android/build/src/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++
-MMD -MF obj/third_party/WebKit/Source/core/html/webcore_html.MediaDocument.o.d
-DANGLE_DX11 -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DDISABLE_NACL
-DCHROMIUM_BUILD -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1
-DUSE_PROPRIETARY_CODECS -DENABLE_CONFIGURATION_POLICY
-DDISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY
-DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DUSE_OPENSSL=1 -DENABLE_EGLIMAGE=1
-DENABLE_AUTOFILL_DIALOG=1 -DCLD_VERSION=1 -DENABLE_PRINTING=1
-DBLINK_IMPLEMENTATION=1 -DINSIDE_BLINK -DENABLE_CUSTOM_SCHEME_HANDLER=0
-DENABLE_ENCRYPTED_MEDIA_V2=1 -DENABLE_SVG_FONTS=1
-DENABLE_GDI_FONTS_ON_WINDOWS=0 -DENABLE_HARFBUZZ_ON_WINDOWS=0
-DENABLE_TOUCH_ICON_LOADING=1 -DWTF_USE_CONCATENATED_IMPULSE_RESPONSES=1
-DENABLE_CALENDAR_PICKER=0 -DENABLE_FAST_MOBILE_SCROLLING=1
-DENABLE_INPUT_SPEECH=0 -DENABLE_LEGACY_NOTIFICATIONS=0 -DENABLE_MEDIA_CAPTURE=1
-DENABLE_ORIENTATION_EVENTS=1 -DENABLE_NAVIGATOR_CONTENT_UTILS=0
-DWTF_USE_WEBAUDIO_OPENMAX_DL_FFT=1 -DENABLE_WEB_AUDIO=1
-DENABLE_OPENTYPE_VERTICAL=1 -DU_USING_ICU_NAMESPACE=0 -DU_STATIC_IMPLEMENTATION
-DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1
'-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"'
-DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1
-DSK_SUPPORT_LEGACY_COLORTYPE=1 -DSK_BUILD_FOR_ANDROID -DSK_USE_POSIX_THREADS
-DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DCHROME_PNG_WRITE_SUPPORT
-DPNG_USER_CONFIG -DLIBXML_STATIC -DLIBXSLT_STATIC -D__STDC_CONSTANT_MACROS
-D__STDC_FORMAT_MACROS -DANDROID -D__GNU_SOURCE=1 -DUSE_STLPORT=1
-D_STLP_USE_PTR_SPECIALIZATIONS=1 '-DCHROME_BUILD_ID=""' -DHAVE_SYS_UIO_H
-DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2
-I../../third_party/khronos -I../../gpu -I../.. -I../../third_party/WebKit
-I../../third_party/WebKit/Source -Igen/blink -Igen/blink/bindings
-I../../third_party/openmax_dl -I../../third_party/angle_dx11/include
-I../../third_party/icu/source/i18n -I../../third_party/icu/source/common
-I../../third_party/skia/src/core -I../../third_party/skia/include/core
-I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf
-I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy
-I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe
-I../../third_party/skia/include/ports -I../../third_party/skia/include/utils
-I../../skia/config -I../../skia/ext -I../../third_party/iccjpeg
-I../../third_party/libpng -I../../third_party/libwebp
-I../../third_party/libxml/linux/include -I../../third_party/libxml/src/include
-I../../third_party/libxslt -I../../third_party/npapi
-I../../third_party/npapi/bindings -I../../third_party/ots/include
-I../../third_party/qcms/src -I../../third_party/sqlite -I../../third_party/zlib
-I../../v8/include -I../../third_party/libjpeg_turbo -fstack-protector
--param=ssp-buffer-size=4 -Werror -fno-exceptions -fno-strict-aliasing -Wall
-Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe
-fPIC -march=armv7-a -mtune=cortex-a8 -mfpu=vfpv3-d16 -mfloat-abi=softfp -mthumb
-fno-tree-sra -fuse-ld=gold -Wno-psabi -mthumb-interwork -ffunction-sections
-funwind-tables -g -fstack-protector -fno-short-enums -finline-limit=64
-Wa,--noexecstack
--sysroot=/mnt/scratch0/b_used/build/slave/android/build/src/third_party/android_tools/ndk//platforms/android-14/arch-arm
-I/mnt/scratch0/b_used/build/slave/android/build/src/third_party/android_tools/ndk//sources/cxx-stl/stlport/stlport
-Os -fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -g1
-fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare
-Wno-c++0x-compat -Wno-abi  -c
../../third_party/WebKit/Source/core/html/MediaDocument.cpp -o
obj/third_party/WebKit/Source/core/html/webcore_html.MediaDocument.o
In file included from
../../third_party/WebKit/Source/core/html/MediaDocument.cpp:45:0:
../../third_party/WebKit/Source/platform/KeyboardCodes.h:38:43: fatal error:
platform/WindowsKeyboardCodes.h: No such file or directory
compilation terminated.
ninja: build stopped: subcommand failed.

[abarth-chromium, 2013-11-05 18:04:03]

> platform/WindowsKeyboardCodes.h: No such file or directory

A	 Source/platform/KeyboardCodes.h

Maybe it's looking for something with Windows in the name?

[pilgrim_google, 2013-11-05 18:06:55]

On 2013/11/05 18:04:03, abarth wrote:
> > platform/WindowsKeyboardCodes.h: No such file or directory
> 
> A	 Source/platform/KeyboardCodes.h
> 
> Maybe it's looking for something with Windows in the name?

platform/WindowsKeyboardCodes.h exists.

[pilgrim_google, 2013-12-10 21:27:50]

rebase

[commit-bot: I haz the power, 2013-12-10 23:03:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pilgrim@chromium.org/60153002/100001

[commit-bot: I haz the power, 2013-12-13 14:47:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pilgrim@chromium.org/60153002/100001

[commit-bot: I haz the power, 2013-12-13 14:47:30]

Failed to apply patch for Source/web/tests/PopupMenuTest.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/web/tests/PopupMenuTest.cpp
  Hunk #1 FAILED at 50.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/web/tests/PopupMenuTest.cpp.rej

Patch:       Source/web/tests/PopupMenuTest.cpp
Index: Source/web/tests/PopupMenuTest.cpp
diff --git a/Source/web/tests/PopupMenuTest.cpp
b/Source/web/tests/PopupMenuTest.cpp
index
0cc21d564455f6615010d2e5b9e5d405fa90f6f3..0fa10e32282ca05a57f754f669b3899dabe423d1
100644
--- a/Source/web/tests/PopupMenuTest.cpp
+++ b/Source/web/tests/PopupMenuTest.cpp
@@ -50,7 +50,7 @@
 #include "core/html/HTMLSelectElement.h"
 #include "core/page/EventHandler.h"
 #include "core/platform/PopupMenuClient.h"
-#include "core/platform/chromium/KeyboardCodes.h"
+#include "platform/KeyboardCodes.h"
 #include "platform/PlatformMouseEvent.h"
 #include "platform/PopupMenu.h"
 #include "platform/graphics/Color.h"

[commit-bot: I haz the power, 2013-12-13 14:56:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pilgrim@chromium.org/60153002/120001

[commit-bot: I haz the power, 2013-12-13 15:02:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pilgrim@chromium.org/60153002/140001

[commit-bot: I haz the power, 2013-12-13 15:55:51]

Retried try job too often on win_layout for step(s) webkit_lint
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-12-13 16:29:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pilgrim@chromium.org/60153002/150001

[commit-bot: I haz the power, 2013-12-13 17:22:44]

Retried try job too often on win_layout for step(s) webkit_lint
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-12-16 14:53:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pilgrim@chromium.org/60153002/170001

[commit-bot: I haz the power, 2013-12-16 16:51:54]

Change committed as 163967