Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 601513002: Add test runner support for overriding web_security_enabled preference. (Closed)

Created:
6 years, 3 months ago by sof
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add test runner support for overriding web_security_enabled preference. Have TestRunner::OverridePreference() recognize "WebKitWebSecurityEnabled" as a boolean preference which controls the web_security_enabled web preference. R=mkwst,jochen BUG=254993 Committed: https://crrev.com/b45d62cc833513e74b1550284900e3c52f93706a Cr-Commit-Position: refs/heads/master@{#296543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/shell/common/test_runner/test_preferences.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/common/test_runner/test_preferences.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/common/webkit_test_helpers.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
sof
Please take a look. I couldn't find a way to control the webSecurityEnabled setting from ...
6 years, 3 months ago (2014-09-23 21:47:33 UTC) #2
Mike West
LGTM. Though I question the value of having the pref in the first place, we ...
6 years, 3 months ago (2014-09-24 08:43:45 UTC) #3
sof
On 2014/09/24 08:43:45, Mike West wrote: > LGTM. Though I question the value of having ...
6 years, 3 months ago (2014-09-24 11:12:52 UTC) #4
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-24 20:05:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601513002/1
6 years, 3 months ago (2014-09-24 21:32:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 707acbbe9d6bdeee23ae2c94a72cae98c28602ae
6 years, 3 months ago (2014-09-24 22:24:23 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 22:25:11 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b45d62cc833513e74b1550284900e3c52f93706a
Cr-Commit-Position: refs/heads/master@{#296543}

Powered by Google App Engine
This is Rietveld 408576698