Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 601473002: Revert of Removing browser.Start() and instead starts the browser at the point of creation. (Closed)

Created:
6 years, 3 months ago by wuhu
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Removing browser.Start() and instead starts the browser at the point of creation. (patchset #6 id:120001 of https://codereview.chromium.org/565803002/) Reason for revert: investigate build error Original issue's description: > Removing browser.Start() and instead starts the browser at the point of creation. > > BUG=412126 > > Committed: https://crrev.com/01c68e8765254d9971296b291ff718b4f6af3004 > Cr-Commit-Position: refs/heads/master@{#295591} > > Committed: https://crrev.com/74c6ef17a08754abadb6fb64da14249898285fa8 > Cr-Commit-Position: refs/heads/master@{#296107} TBR=nednguyen@google.com,slamm@chromium.org,slamm@google.com NOTREECHECKS=true NOTRY=true BUG=412126 Committed: https://crrev.com/de9555146d87d2daf5e2e1da425d46b8efc06415 Cr-Commit-Position: refs/heads/master@{#296247}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -80 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py View 1 chunk +1 line, -6 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py View 1 chunk +1 line, -6 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/cros_browser_with_oobe.py View 1 chunk +2 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py View 1 chunk +1 line, -6 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py View 1 chunk +1 line, -6 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py View 1 chunk +1 line, -6 lines 0 comments Download
M tools/telemetry/telemetry/core/browser.py View 3 chunks +18 lines, -23 lines 0 comments Download
M tools/telemetry/telemetry/core/browser_credentials.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/extension_unittest.py View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/possible_browser.py View 2 chunks +0 lines, -13 lines 0 comments Download
M tools/telemetry/telemetry/page/page_runner.py View 1 chunk +6 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/unittest/browser_test_case.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
wuhu
Created Revert of Removing browser.Start() and instead starts the browser at the point of creation.
6 years, 3 months ago (2014-09-23 18:10:37 UTC) #1
nednguyen
lgtm
6 years, 3 months ago (2014-09-23 18:13:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601473002/1
6 years, 3 months ago (2014-09-23 20:31:48 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0922870a1f25e68f841fde373d014eb4319f753a
6 years, 3 months ago (2014-09-23 21:15:47 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 21:16:23 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de9555146d87d2daf5e2e1da425d46b8efc06415
Cr-Commit-Position: refs/heads/master@{#296247}

Powered by Google App Engine
This is Rietveld 408576698