Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 601403004: Do not run extensions_unittests on memory trybot (Closed)

Created:
6 years, 2 months ago by Paweł Hajdan Jr.
Modified:
6 years, 2 months ago
Reviewers:
phajdan, tfarina, jam
CC:
chromium-reviews, James Cook, Yoyo Zhou, Dirk Pranke, darin (slow to review), tfarina, Derek Bruening, Timur Iskhodzhanov, Lei Zhang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Do not run extensions_unittests on memory trybot They don't run on memory main waterfall bots. BUG=387743, 416665 R=jam@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/8bbaa87b58535ffa402536c878ff2faaf4f7ac28

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M testing/buildbot/chromium_memory_trybot.json View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
phajdan
6 years, 2 months ago (2014-09-25 23:40:56 UTC) #2
jam
lgtm I added 416665 to the bug list
6 years, 2 months ago (2014-09-26 21:20:32 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8bbaa87b58535ffa402536c878ff2faaf4f7ac28 Cr-Commit-Position: refs/heads/master@{#297037}
6 years, 2 months ago (2014-09-26 21:25:07 UTC) #5
Paweł Hajdan Jr.
Committed patchset #1 (id:1) manually as 8bbaa87 (presubmit successful).
6 years, 2 months ago (2014-09-26 21:25:17 UTC) #6
James Cook
On 2014/09/26 21:25:17, Paweł Hajdan Jr. wrote: > Committed patchset #1 (id:1) manually as 8bbaa87 ...
6 years, 2 months ago (2014-09-27 01:18:22 UTC) #7
tfarina
Why the author and reviewers were not copied this in this revert? I think it ...
6 years, 2 months ago (2014-09-27 01:39:30 UTC) #8
tfarina
Copying more memory devs. Could you document in http://www.chromium.org/developers/testing/adding-tests-to-the-main-waterfall the steps that should be followed ...
6 years, 2 months ago (2014-09-27 01:43:46 UTC) #10
tfarina
6 years, 2 months ago (2014-09-27 01:46:13 UTC) #11
Message was sent while issue was closed.
It runs on memory.fyi though.
https://chromium.googlesource.com/chromium/src/+/master/testing/buildbot/chro...

Not on the main waterfall (yet) it seems.

Powered by Google App Engine
This is Rietveld 408576698