Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 601293003: [Pepper][Compositor] Fix the compositor stops updating texture issue. (Closed)

Created:
6 years, 2 months ago by Peng
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Pepper][Compositor] Fix the compositor stops updating texture issue. BUG=417408 Committed: https://crrev.com/b25533eb65de20237dff5ea50606e3339e9bd9ca Cr-Commit-Position: refs/heads/master@{#296952}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address review issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M content/renderer/pepper/pepper_compositor_host.cc View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Peng
On 2014/09/25 20:22:34, Peng wrote: > mailto:penghuang@chromium.org changed reviewers: > + mailto:dmichael@chromium.org Hi Dana & ...
6 years, 2 months ago (2014-09-25 20:23:02 UTC) #3
danakj
LGTM https://codereview.chromium.org/601293003/diff/1/content/renderer/pepper/pepper_compositor_host.cc File content/renderer/pepper/pepper_compositor_host.cc (right): https://codereview.chromium.org/601293003/diff/1/content/renderer/pepper/pepper_compositor_host.cc#newcode262 content/renderer/pepper/pepper_compositor_host.cc:262: texture_layer->SetNeedsDisplay(); Can you add a TODO that you ...
6 years, 2 months ago (2014-09-25 20:25:20 UTC) #4
Peng
https://codereview.chromium.org/601293003/diff/1/content/renderer/pepper/pepper_compositor_host.cc File content/renderer/pepper/pepper_compositor_host.cc (right): https://codereview.chromium.org/601293003/diff/1/content/renderer/pepper/pepper_compositor_host.cc#newcode262 content/renderer/pepper/pepper_compositor_host.cc:262: texture_layer->SetNeedsDisplay(); On 2014/09/25 20:25:20, danakj wrote: > Can you ...
6 years, 2 months ago (2014-09-25 20:37:52 UTC) #5
dmichael (off chromium)
OWNERS lgtm
6 years, 2 months ago (2014-09-26 15:12:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601293003/20001
6 years, 2 months ago (2014-09-26 15:16:54 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as a036abd0bc8b465ded64490602f41b870354958e
6 years, 2 months ago (2014-09-26 15:48:54 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 15:49:56 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b25533eb65de20237dff5ea50606e3339e9bd9ca
Cr-Commit-Position: refs/heads/master@{#296952}

Powered by Google App Engine
This is Rietveld 408576698