chromecast/shell/android/apk/src/org/chromium/chromecast/shell/CastShellActivity.java - Issue 601293002: Chromecast: call ClosePage(), wait 50ms before deleting WebContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/shell/android/apk/src/org/chromium/chromecast/shell/CastShellActivity.java

Issue 601293002: Chromecast: call ClosePage(), wait 50ms before deleting WebContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comment nit, rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chromecast/shell/android/apk/src/org/chromium/chromecast/shell/CastShellActivity.java

diff --git a/chromecast/shell/android/apk/src/org/chromium/chromecast/shell/CastShellActivity.java b/chromecast/shell/android/apk/src/org/chromium/chromecast/shell/CastShellActivity.java

index 2eacf956df3a90c19373effe148abe84c1bd9581..46152e7b6329fdaae7f092231eb84e1d629445cd 100644

--- a/chromecast/shell/android/apk/src/org/chromium/chromecast/shell/CastShellActivity.java

+++ b/chromecast/shell/android/apk/src/org/chromium/chromecast/shell/CastShellActivity.java

@@ -120,7 +120,7 @@ public class CastShellActivity extends Activity {

unregisterBroadcastReceiver();

if (mNativeCastWindow != 0) {

- mCastWindowManager.stopCastWindow(mNativeCastWindow);

+ mCastWindowManager.stopCastWindow(mNativeCastWindow, false /* gracefully */);

mNativeCastWindow = 0;

}

@@ -176,7 +176,7 @@ public class CastShellActivity extends Activity {

protected void finishGracefully() {

if (mNativeCastWindow != 0) {

- mCastWindowManager.stopCastWindow(mNativeCastWindow);

+ mCastWindowManager.stopCastWindow(mNativeCastWindow, true /* gracefully */);

mNativeCastWindow = 0;

}

« no previous file with comments | « no previous file | chromecast/shell/android/apk/src/org/chromium/chromecast/shell/CastWindowManager.java » ('j') | no next file with comments »