Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: chromecast/shell/android/apk/src/org/chromium/chromecast/shell/CastWindowManager.java

Issue 601293002: Chromecast: call ClosePage(), wait 50ms before deleting WebContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/shell/android/apk/src/org/chromium/chromecast/shell/CastWindowManager.java
diff --git a/chromecast/shell/android/apk/src/org/chromium/chromecast/shell/CastWindowManager.java b/chromecast/shell/android/apk/src/org/chromium/chromecast/shell/CastWindowManager.java
index a8aca376072896409ea770f3fd27dccda5e1e3c3..9af874e78c7d00ef00c32a25031ad2443286faca 100644
--- a/chromecast/shell/android/apk/src/org/chromium/chromecast/shell/CastWindowManager.java
+++ b/chromecast/shell/android/apk/src/org/chromium/chromecast/shell/CastWindowManager.java
@@ -98,10 +98,12 @@ public class CastWindowManager extends FrameLayout {
* Stops a native cast shell instance created by {@link #launchCastWindow(String)}.
* @param nativeCastWindow Pointer of native cast shell instance returned
* by {@link #launchCastWindow(String)}.
+ * @param gracefully Whether or not to give a time interval to deliver window.unload event
lcwu1 2014/09/25 19:10:54 I would change this comment to be something like "
gunsch 2014/09/25 19:18:14 Done.
+ * the the receiver app.
* @see #launchCastWindow(String)
*/
- public void stopCastWindow(long nativeCastWindow) {
- nativeStopCastWindow(nativeCastWindow);
+ public void stopCastWindow(long nativeCastWindow, boolean gracefully) {
+ nativeStopCastWindow(nativeCastWindow, gracefully);
}
@SuppressWarnings("unused")
@@ -150,6 +152,7 @@ public class CastWindowManager extends FrameLayout {
private static native void nativeInit(Object shellManagerInstance);
private static native long nativeLaunchCastWindow(String url);
- private static native void nativeStopCastWindow(long pointerOfNativeCastWindow);
+ private static native void nativeStopCastWindow(long pointerOfNativeCastWindow,
+ boolean gracefully);
public static native void nativeEnableDevTools(boolean enable);
}

Powered by Google App Engine
This is Rietveld 408576698