Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 601273002: Define ViewMsg_ColorProfile and plumb it into RenderWidget (Closed)

Created:
6 years, 2 months ago by Noel Gordon
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, Justin Novosad, Ken Russell (switch to Gerrit), mkwst+moarreviews-renderer_chromium.org, Stephen White, sugoi1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Define ViewMsg_ColorProfile and plumb it into RenderWidget Define ViewMsg_ColorProfile IPC message and plumb it into renderer RenderWidget::SetDeviceColorProfile(). The browser uses the IPC to set the renderers screen color profile. Note SetDeviceColorProfile is overridden by RenderViewImpl, so the IPC message data is handled there - it calls the base RenderWidget SetDeviceColorProfile, which detects if the color profile changed, and stores it in the RenderWidget if so. If there was a change, the RenderViewImpl informs its webview() so the Page contained therein can update / repaint all color profiled elements on the Page. For a diagram of the IPC and procedure call proceedings, including layout test support (added in issue 369787), see: https://crbug.com/368663#c14 Not used as yet: the IPC from the browser-side will be added later (need to resolve issue 338130, issue 357443 first), so this change is again just plumbing. CQ_EXTRA_TRYBOTS=tryserver.blink:mac_blink_rel,mac_blink_dbg BUG=368663 Committed: https://crrev.com/89949e66232b21fe55eeccd1d2353261de90c275 Cr-Commit-Position: refs/heads/master@{#297328}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M content/common/view_messages.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/render_widget.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_widget.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Noel Gordon
Add ViewMsg_ColorProfile.
6 years, 2 months ago (2014-09-25 16:00:50 UTC) #2
jochen (gone - plz use gerrit)
you'll need an IPC review btw, I found a thread on chromium-dev "Best way to ...
6 years, 2 months ago (2014-09-29 12:51:51 UTC) #3
Noel Gordon
On 2014/09/29 12:51:51, jochen wrote: > you'll need an IPC review An IPC review? Adding ...
6 years, 2 months ago (2014-09-29 14:50:28 UTC) #4
Noel Gordon
6 years, 2 months ago (2014-09-29 14:51:20 UTC) #6
Ken Russell (switch to Gerrit)
+palmer,dcheng,wfh for view_messages.h review
6 years, 2 months ago (2014-09-29 20:07:05 UTC) #8
Will Harris
IPC in content/common/view_messages.h lgtm
6 years, 2 months ago (2014-09-29 23:35:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601273002/1
6 years, 2 months ago (2014-09-30 00:33:49 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as 883740f54c9d82805471596dd604fd5358131677
6 years, 2 months ago (2014-09-30 01:12:50 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 01:14:22 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/89949e66232b21fe55eeccd1d2353261de90c275
Cr-Commit-Position: refs/heads/master@{#297328}

Powered by Google App Engine
This is Rietveld 408576698