Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Issue 601243003: cc: Default value for use_distance_field_text was not set in the layer tree settings (Closed)

Created:
6 years, 2 months ago by hendrikw
Modified:
6 years, 2 months ago
Reviewers:
danakj, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Default value for use_distance_field_text was not set in the layer tree settings This was causing many ResourceProviders to be created with distance field text randomly set to on or off. Because AcquireSkSurface was never called on those instances of ResourceProvider, it isn't a serious problem, but I fixed it anyway, safer this way. Committed: https://crrev.com/cb1436825a88e160208ef4f677856058d4ec371c Cr-Commit-Position: refs/heads/master@{#296742}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M cc/trees/layer_tree_settings.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
hendrikw
Really minor change, PTAL, thanks!
6 years, 2 months ago (2014-09-25 16:45:10 UTC) #2
danakj
This would affect tests and the browser compositor since RWC always sets it. LGTM
6 years, 2 months ago (2014-09-25 16:46:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601243003/1
6 years, 2 months ago (2014-09-25 16:51:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 89954a07b5efd331b2f1063a0ec0ee672eac38a6
6 years, 2 months ago (2014-09-25 18:03:08 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 18:03:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb1436825a88e160208ef4f677856058d4ec371c
Cr-Commit-Position: refs/heads/master@{#296742}

Powered by Google App Engine
This is Rietveld 408576698