Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 601243002: Remove unneeded Friend from chrome_metrics_service_accessor (Closed)

Created:
6 years, 2 months ago by csharp
Modified:
6 years, 2 months ago
CC:
chromium-reviews, Ilya Sherman, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove unneeded Friend from chrome_metrics_service_accessor BUG= Committed: https://crrev.com/ca032c3aed93e5afd7c32da76147f36a72dc4341 Cr-Commit-Position: refs/heads/master@{#296722}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M chrome/browser/metrics/chrome_metrics_service_accessor.h View 3 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
csharp
6 years, 2 months ago (2014-09-25 15:26:26 UTC) #3
Alexei Svitkine (slow)
lgtm
6 years, 2 months ago (2014-09-25 15:26:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601243002/20001
6 years, 2 months ago (2014-09-25 15:32:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001) as 3de298049c87606292839628a9b35a0520d74151
6 years, 2 months ago (2014-09-25 16:40:54 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ca032c3aed93e5afd7c32da76147f36a72dc4341 Cr-Commit-Position: refs/heads/master@{#296722}
6 years, 2 months ago (2014-09-25 16:41:39 UTC) #8
MAD
6 years, 2 months ago (2014-09-25 19:22:49 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.chromium.org/603173003/ by mad@chromium.org.

The reason for reverting is: We need to bring this back since the usage of it is
coming back in an upcoming patch.

Sorry about that...

BYE
MAD
.

Powered by Google App Engine
This is Rietveld 408576698