Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 601213002: Fix mojom Java generator running on its own. (Closed)

Created:
6 years, 2 months ago by ppi
Modified:
6 years, 2 months ago
Reviewers:
qsr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix mojom Java generator running on its own. It turns out that running self.GetStructs() not only gives you the structs, but changes the state of the module, annotating structs with necessary information. Therefore we need to run .GetStructs() in the Java generator as we do in the other generators. This patch makes the java generation work on it's own, ie. with "-g java". Committed: https://crrev.com/a82c0a5f1cc8519f5c9fdf20e65268fbc5929173 Cr-Commit-Position: refs/heads/master@{#296718}

Patch Set 1 #

Patch Set 2 : Address Ben's (off-cl) comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M mojo/public/tools/bindings/generators/mojom_java_generator.py View 1 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ppi
ptal
6 years, 2 months ago (2014-09-25 14:22:39 UTC) #2
ppi
ptal
6 years, 2 months ago (2014-09-25 14:54:02 UTC) #3
qsr
lgtm
6 years, 2 months ago (2014-09-25 15:00:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601213002/20001
6 years, 2 months ago (2014-09-25 15:03:38 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as f4eb8fd7168dbfebd11c40e859d6b73f9f25ffa0
6 years, 2 months ago (2014-09-25 16:15:30 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 16:16:08 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a82c0a5f1cc8519f5c9fdf20e65268fbc5929173
Cr-Commit-Position: refs/heads/master@{#296718}

Powered by Google App Engine
This is Rietveld 408576698