Issue 6012007: wm: Fix FD leak in watchdog when Chrome is hanging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6012007: wm: Fix FD leak in watchdog when Chrome is hanging. (Closed)

Created:
10 years ago by Daniel Erat

Modified:
9 years, 7 months ago

Reviewers:
oshima

CC:
chromium-os-reviews_chromium.org, Greg Spencer (Chromium), Daniel Erat

Base URL:
ssh://git@gitrw.chromium.org:9222/window_manager.git@master

Visibility:
Public.

Description

wm: Fix FD leak in watchdog when Chrome is hanging. When Chrome's UI thread didn't respond to pings, timeouts weren't being removed. This could result in us leaking timerfd file descriptors at a rate of one every five seconds. BUG=chromium-os:10583 TEST=added a test that catches the problem in the old code Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=4bef394

Patch Set 1 #

Patch Set 2 : fix typo in comment #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -9 lines)			Patch
M	chrome_watchdog.cc	View		2 chunks	+3 lines, -6 lines	0 comments	Download
M	chrome_watchdog_test.cc	View	1	3 chunks	+9 lines, -3 lines	0 comments	Download
M	event_loop.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages