Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 601173002: Html main tag is not exposed with correct IA2 ROLE (Closed)

Created:
6 years, 2 months ago by shreeramk
Modified:
6 years, 2 months ago
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Html main tag is not exposed with correct IA2 ROLE main tag or aria role main is not exposed with correct IA2 role. The correct IA2 role for main is ROLE_SYSTEM_GROUPING BUG=417654 Committed: https://crrev.com/4b91c2d8f69f657868ed3a420a67e53ca4ad38c0 Cr-Commit-Position: refs/heads/master@{#296896}

Patch Set 1 #

Patch Set 2 : Adding expectations for mac and android #

Patch Set 3 : Updating expectations for win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -3 lines) Patch
M content/browser/accessibility/browser_accessibility_win.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/test/data/accessibility/landmark-expected-win.txt View 1 2 chunks +2 lines, -2 lines 0 comments Download
A content/test/data/accessibility/main.html View 1 chunk +18 lines, -0 lines 0 comments Download
A content/test/data/accessibility/main-expected-android.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/main-expected-mac.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/accessibility/main-expected-win.txt View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shreeramk
I ll update the test expectations tomorrow.(Sorry, I am at home) Please review. Thanks!
6 years, 2 months ago (2014-09-25 16:22:54 UTC) #2
dmazzoni
lgtm
6 years, 2 months ago (2014-09-25 16:27:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601173002/40001
6 years, 2 months ago (2014-09-26 05:35:04 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 8c262b1e1d063eb936882e15b1aab75d3f4fdd4d
6 years, 2 months ago (2014-09-26 06:45:28 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 06:46:09 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/4b91c2d8f69f657868ed3a420a67e53ca4ad38c0
Cr-Commit-Position: refs/heads/master@{#296896}

Powered by Google App Engine
This is Rietveld 408576698