Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1309)

Issue 601163002: mojo: Fix mojo test on Art runtime. (Closed)

Created:
6 years, 2 months ago by qsr
Modified:
6 years, 2 months ago
Reviewers:
Yaron, ppi
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mojo: Fix mojo test on Art runtime. Due to the following bug: https://code.google.com/p/android/issues/detail?id=76644, it is not possible in art to create an empty buffer for address NULL. This solve the issue by creating an empty buffer on a random address. This is not an issue as the memory will never be accessed. BUG=406848 R=ppi@chromium.org,yfriedman@chromium.org Committed: https://crrev.com/a8af5943653de9ebabbca1ba6378ac4ac3017e2c Cr-Commit-Position: refs/heads/master@{#296964}

Patch Set 1 #

Patch Set 2 : CHECJ size is 0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M mojo/android/javatests/validation_test_util.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
qsr
6 years, 2 months ago (2014-09-25 10:54:27 UTC) #1
qsr
gentle pings?
6 years, 2 months ago (2014-09-26 14:35:44 UTC) #2
Yaron
lgtm (didn't make priority inbox for some reason)
6 years, 2 months ago (2014-09-26 16:26:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601163002/20001
6 years, 2 months ago (2014-09-26 16:28:06 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as e593699ebe2fcfeec0947c5c9a1b1cac21eb1ba7
6 years, 2 months ago (2014-09-26 17:07:33 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 17:08:08 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a8af5943653de9ebabbca1ba6378ac4ac3017e2c
Cr-Commit-Position: refs/heads/master@{#296964}

Powered by Google App Engine
This is Rietveld 408576698