Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 60113007: cc: Define ScrollOffsetAnimationCurve (Closed)

Created:
7 years, 1 month ago by ajuma
Modified:
7 years ago
Reviewers:
Ian Vollick
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Define ScrollOffsetAnimationCurve This defines ScrollOffsetAnimationCurve, which will be used by the implementation of the CSSOM View smooth scroll API. BUG=243871 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237121

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -1 line) Patch
M cc/animation/animation_curve.h View 2 chunks +5 lines, -1 line 1 comment Download
M cc/animation/animation_curve.cc View 2 chunks +12 lines, -0 lines 0 comments Download
A cc/animation/scroll_offset_animation_curve.h View 1 chunk +52 lines, -0 lines 0 comments Download
A cc/animation/scroll_offset_animation_curve.cc View 1 chunk +61 lines, -0 lines 0 comments Download
A cc/animation/scroll_offset_animation_curve_unittest.cc View 1 chunk +80 lines, -0 lines 0 comments Download
M cc/cc.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/cc_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/geometry_test_utils.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ajuma
PTAL. https://codereview.chromium.org/60113007/diff/30001/cc/animation/animation_curve.h File cc/animation/animation_curve.h (right): https://codereview.chromium.org/60113007/diff/30001/cc/animation/animation_curve.h#newcode43 cc/animation/animation_curve.h:43: ScrollOffsetAnimationCurve* ToScrollOffsetAnimationCurve(); We need a non-const version for ...
7 years, 1 month ago (2013-11-20 17:48:27 UTC) #1
Ian Vollick
On 2013/11/20 17:48:27, ajuma wrote: > PTAL. > > https://codereview.chromium.org/60113007/diff/30001/cc/animation/animation_curve.h > File cc/animation/animation_curve.h (right): > ...
7 years ago (2013-11-25 15:25:55 UTC) #2
ajuma
On 2013/11/25 15:25:55, Ian Vollick wrote: > On 2013/11/20 17:48:27, ajuma wrote: > > PTAL. ...
7 years ago (2013-11-25 16:18:16 UTC) #3
Ian Vollick
On 2013/11/25 16:18:16, ajuma wrote: > On 2013/11/25 15:25:55, Ian Vollick wrote: > > On ...
7 years ago (2013-11-25 16:52:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/60113007/30001
7 years ago (2013-11-25 16:55:42 UTC) #5
commit-bot: I haz the power
7 years ago (2013-11-25 19:30:28 UTC) #6
Message was sent while issue was closed.
Change committed as 237121

Powered by Google App Engine
This is Rietveld 408576698