Enable chromium_code=1 on Windows

Source/core/rendering/RenderLayerStackingNode.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  *
  * Portions are Copyright (C) 1998 Netscape Communications Corporation.
  *
  * Other contributors:
  *   Robert O'Callahan <roc+@cs.cmu.edu>
  *   David Baron <dbaron@fas.harvard.edu>
  *   Christian Biesinger <cbiesinger@web.de>
  *   Randall Jesup <rjesup@wgate.com>
@@ skipping 419 matching lines @@
         || renderer()->hasFilter()
         || renderer()->hasBlendMode()
         || layer()->isTransparent()
         || renderer()->isRenderRegion();
 
     return couldBeNormalFlow && !preventsElementFromBeingNormalFlow;
 }
 
 void RenderLayerStackingNode::updateIsNormalFlowOnly()
 {
-    bool isNormalFlowOnly = shouldBeNormalFlowOnly();
-    if (isNormalFlowOnly == m_isNormalFlowOnly)
+    bool newIsNormalFlowOnly = shouldBeNormalFlowOnly();

[dglazkov, 2013/11/06 17:31:05]

Here and elsewhere: would you not be able to resolve shadowing
this->functionName. The "new" prefix just adds confusion.

[Peter Kasting, 2013/11/06 18:41:46]

Personally I think the "new" route reads more clearly, but it sounds like you
guys don't agree :)

+    if (newIsNormalFlowOnly == isNormalFlowOnly())
         return;
 
-    m_isNormalFlowOnly = isNormalFlowOnly;
+    m_isNormalFlowOnly = newIsNormalFlowOnly;
     if (RenderLayer* p = layer()->parent())
         p->stackingNode()->dirtyNormalFlowList();
     dirtyStackingContainerZOrderLists();
 }
 
 bool RenderLayerStackingNode::needsToBeStackingContainer() const
 {
     return layer()->scrollableArea() && layer()->scrollableArea()->adjustForForceCompositedScrollingMode(m_needsToBeStackingContainer);
 }
 
@@ skipping 156 matching lines @@
 
 bool RenderLayerStackingNode::descendantsAreContiguousInStackingOrder() const
 {
     if (isStackingContext() || !ancestorStackingContainerNode())
         return true;
 
     ASSERT(!m_descendantsAreContiguousInStackingOrderDirty);
     return m_descendantsAreContiguousInStackingOrder;
 }
 
-bool RenderLayerStackingNode::setNeedsToBeStackingContainer(bool needsToBeStackingContainer)
+bool RenderLayerStackingNode::setNeedsToBeStackingContainer(bool newNeedsToBeStackingContainer)
 {
-    if (m_needsToBeStackingContainer == needsToBeStackingContainer)
+    if (needsToBeStackingContainer() == newNeedsToBeStackingContainer)
         return false;
 
     // Count the total number of RenderLayers which need to be stacking
     // containers some point. This should be recorded at most once per
     // RenderLayer, so we check m_needsToBeStackingContainerHasBeenRecorded.
     if (layer()->acceleratedCompositingForOverflowScrollEnabled() && !m_needsToBeStackingContainerHasBeenRecorded) {
         WebKit::Platform::current()->histogramEnumeration("Renderer.CompositedScrolling", RenderLayer::NeedsToBeStackingContainerBucket, RenderLayer::CompositedScrollingHistogramMax);
         m_needsToBeStackingContainerHasBeenRecorded = true;
     }
 
-    m_needsToBeStackingContainer = needsToBeStackingContainer;
+    m_needsToBeStackingContainer = newNeedsToBeStackingContainer;
 
     return true;
 }
 
 RenderLayerStackingNode* RenderLayerStackingNode::ancestorStackingContainerNode() const
 {
     RenderLayer* ancestor = layer()->parent();
     while (ancestor && !ancestor->stackingNode()->isStackingContainer())
         ancestor = ancestor->parent();
     if (ancestor)
@@ skipping 10 matching lines @@
         return ancestor->stackingNode();
     return 0;
 }
 
 RenderLayerModelObject* RenderLayerStackingNode::renderer() const
 {
     return m_layer->renderer();
 }
 
 } // namespace WebCore