Enable chromium_code=1 on Windows

Source/config.gyp

 #
 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
@@ skipping 25 matching lines @@
   'targets': [
   {
     'target_name': 'config',
     'type': 'none',
     'direct_dependent_settings': {
       'include_dirs': [
         '.',
         '..',
       ],
       'msvs_disabled_warnings': [
-        4138, 4244, 4291, 4305, 4344, 4355, 4521, 4099,
+        4138, 4244, 4291, 4305, 4344, 4355, 4521, 4099, 4800, 4996,

[scottmg, 2013/11/06 04:40:48]

4800 is "forcing value to bool 'true' or 'false' (performance warning)"

4996 is "using POSIX name instead of ISO name" (in this case strdup instead of
_strdup).

Both seem silly to me. We should probably turn them off in build/common.gypi
too.

[Peter Kasting, 2013/11/06 07:20:02]

I don't think they're huge deals, but what would we lose by simply fixing them? 
The first can be fixed (where existing code is correct) using any of
"static_cast<bool>(...)", "... != 0", or "!!...", and seems like it could
potentially catch cases where people unintentionally use a numeric value as a
boolean one.  For the second, does using thee ISO names create portability
problems?

(Note: We could fix these in a separate CL, if there are a lot.)

       ],
+      'variables': {
+        'chromium_code': 1,

[Peter Kasting, 2013/11/06 07:20:02]

This doesn't go into the variables section at the top?

+      },
       'conditions': [
         ['OS=="win" and component=="shared_library"', {
           'defines': [
             'USING_V8_SHARED',
           ],
         }],
         ['OS=="win"', {
           'sources/': [
             ['exclude', 'Posix\\.cpp$'],
           ],
@@ skipping 24 matching lines @@
         ['gcc_version>=46', {
           # Disable warnings about c++0x compatibility, as some names (such as
           # nullptr) conflict with upcoming c++0x types.
           'cflags_cc': ['-Wno-c++0x-compat'],
         }],
         ['OS=="linux" and target_arch=="arm"', {
           # Due to a bug in gcc arm, we get warnings about uninitialized
           # timesNewRoman.unstatic.3258 and colorTransparent.unstatic.4879.
           'cflags': ['-Wno-uninitialized'],
         }],
-        ['OS!="win"', {
-          # TODO: Turn this on on all platforms, http://crbug.com/312287
-          'variables': {
-            'chromium_code': 1,
-          },
-        }],
         ['clang==1', {
           'cflags': ['-Wglobal-constructors'],
           'xcode_settings': {
             'WARNING_CFLAGS': ['-Wglobal-constructors'],
           },
         }],
       ],
     },
   },
   {
@@ skipping 11 matching lines @@
     ],
     'direct_dependent_settings': {
       'cflags!': ['-Wglobal-constructors'],
       'xcode_settings': {
         'WARNING_CFLAGS!': ['-Wglobal-constructors'],
       },
     },
   }
   ],
 }