Add a flag to skip robot token fetching for testing device enrollments.

Add a flag to skip robot token fetching for testing device enrollments.

None of the testing server implementations are currently capable of minting
robot OAuth tokens and testing of device enrollment was only possible against
actual DMServer. With this flag it will be possible to successfully complete
enrollment while still testing the whole enrollment handshake and only skipping
the step where the robot token is fetched from GAIA.

BUG=313811
TEST=Enrollment against YAPS should succeed.
R=joaodasilva@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233262

[pastarmovj, 2013-11-05 15:29:08]

PTAL.

[Joao da Silva, 2013-11-05 16:25:48]

https://codereview.chromium.org/60113002/diff/1/chrome/browser/chromeos/polic...
File chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc (right):

https://codereview.chromium.org/60113002/diff/1/chrome/browser/chromeos/polic...
chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc:354: if
(!token_service->SetAndSaveRefreshToken(refresh_token_)) {
I think this block could be skipped when the switch is set, instead of setting
refresh_token_ to the mock value. WDYT?

https://codereview.chromium.org/60113002/diff/1/chrome/common/chrome_switches.h
File chrome/common/chrome_switches.h (right):

https://codereview.chromium.org/60113002/diff/1/chrome/common/chrome_switches...
chrome/common/chrome_switches.h:233: extern const char
kEnrollmentSkipRobotAuth[];
This should go in src/chromeos/chromeos_switches.h

[pastarmovj, 2013-11-05 16:38:58]

Thanks  for the review. PTAL. :)

https://codereview.chromium.org/60113002/diff/1/chrome/browser/chromeos/polic...
File chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc (right):

https://codereview.chromium.org/60113002/diff/1/chrome/browser/chromeos/polic...
chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc:354: if
(!token_service->SetAndSaveRefreshToken(refresh_token_)) {
On 2013/11/05 16:25:48, Joao da Silva wrote:
> I think this block could be skipped when the switch is set, instead of setting
> refresh_token_ to the mock value. WDYT?

Actually I think it is better to set it to this obviously fake value to make it
clear that this code path has been taken. Not setting anything in this pref
might be harder to track down in case we will have investigate issues around
this code.

https://codereview.chromium.org/60113002/diff/1/chrome/common/chrome_switches.h
File chrome/common/chrome_switches.h (right):

https://codereview.chromium.org/60113002/diff/1/chrome/common/chrome_switches...
chrome/common/chrome_switches.h:233: extern const char
kEnrollmentSkipRobotAuth[];
On 2013/11/05 16:25:48, Joao da Silva wrote:
> This should go in src/chromeos/chromeos_switches.h

Done and renamed to fit in the general schema.

[Joao da Silva, 2013-11-05 16:40:59]

lgtm

[commit-bot: I haz the power, 2013-11-05 16:53:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/60113002/80001

[commit-bot: I haz the power, 2013-11-05 18:26:30]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-06 09:02:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/60113002/80001

[commit-bot: I haz the power, 2013-11-06 12:15:00]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-11-06 12:18:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/60113002/80001

[pastarmovj, 2013-11-06 13:02:18]

Committed patchset #2 manually as r233262 (presubmit successful).