Add a trivial logging wrapper around console.log, and add some useful log

Add a trivial logging wrapper around console.log, and add some useful log
messages.

BUG=397019
Committed: https://crrev.com/31eb32766f8f1adfd7bd5f8a060b3795541fad59
Cr-Commit-Position: refs/heads/master@{#297366}

[Anand Mistry (off Chromium), 2014-09-25 07:10:36]

amistry@chromium.org changed reviewers:
+ dbeam@chromium.org, rlp@chromium.org

[Anand Mistry (off Chromium), 2014-09-25 07:10:36]

I want to have log messages in the code, which are useful while developing, but
using straight console.log seems to be a no-no. So here's a trivial wrapper that
lets me turn on logging in local builds, and keep log messages in the code.
Hopefully, not too crazy a proposal.

[Dan Beam, 2014-09-29 23:45:45]

https://codereview.chromium.org/601123002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/hotword/logging.js (right):

https://codereview.chromium.org/601123002/diff/20001/chrome/browser/resources...
chrome/browser/resources/hotword/logging.js:1: // Copyright (c) 2014 The
Chromium Authors. All rights reserved.
s/ (c)//

https://codereview.chromium.org/601123002/diff/20001/chrome/browser/resources...
chrome/browser/resources/hotword/logging.js:8: var DEBUG = false;
why not some externally visible member (e.g. hotword.DEBUG)?  you can set this
from outside the program (in addition to changing the code locally).

https://codereview.chromium.org/601123002/diff/20001/chrome/browser/resources...
chrome/browser/resources/hotword/logging.js:15: if (DEBUG) {
nit: chrome-code generally doesn't use {} for 1-line conditionals

https://codereview.chromium.org/601123002/diff/20001/chrome/browser/resources...
chrome/browser/resources/hotword/logging.js:17: }
nit: if you already need to change the code locally, why not:

  if (0)

or

  // Uncomment for glorious debug log spam.
  // console.log.apply(console, arguments);

https://codereview.chromium.org/601123002/diff/20001/chrome/browser/resources...
chrome/browser/resources/hotword/logging.js:21: Debug: Debug
Debug => debug

[rpetterson, 2014-09-30 00:13:20]

lgtm

[Anand Mistry (off Chromium), 2014-09-30 03:41:10]

https://codereview.chromium.org/601123002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/hotword/logging.js (right):

https://codereview.chromium.org/601123002/diff/20001/chrome/browser/resources...
chrome/browser/resources/hotword/logging.js:1: // Copyright (c) 2014 The
Chromium Authors. All rights reserved.
On 2014/09/29 23:45:45, Dan Beam wrote:
> s/ (c)//

Done.

https://codereview.chromium.org/601123002/diff/20001/chrome/browser/resources...
chrome/browser/resources/hotword/logging.js:8: var DEBUG = false;
On 2014/09/29 23:45:44, Dan Beam wrote:
> why not some externally visible member (e.g. hotword.DEBUG)?  you can set this
> from outside the program (in addition to changing the code locally).

Done.

https://codereview.chromium.org/601123002/diff/20001/chrome/browser/resources...
chrome/browser/resources/hotword/logging.js:15: if (DEBUG) {
On 2014/09/29 23:45:45, Dan Beam wrote:
> nit: chrome-code generally doesn't use {} for 1-line conditionals

Oops. That one slipped by.

https://codereview.chromium.org/601123002/diff/20001/chrome/browser/resources...
chrome/browser/resources/hotword/logging.js:17: }
On 2014/09/29 23:45:44, Dan Beam wrote:
> nit: if you already need to change the code locally, why not:
> 
>   if (0)
> 
> or
> 
>   // Uncomment for glorious debug log spam.
>   // console.log.apply(console, arguments);

I like the idea to expose DEBUG so I can enable it at runtime, so I've done that
instead.

https://codereview.chromium.org/601123002/diff/20001/chrome/browser/resources...
chrome/browser/resources/hotword/logging.js:21: Debug: Debug
On 2014/09/29 23:45:44, Dan Beam wrote:
> Debug => debug

Done.

[Dan Beam, 2014-09-30 03:42:58]

lgtm

https://codereview.chromium.org/601123002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/hotword/logging.js (right):

https://codereview.chromium.org/601123002/diff/40001/chrome/browser/resources...
chrome/browser/resources/hotword/logging.js:8: var DEBUG = false;
nit: just remove this

https://codereview.chromium.org/601123002/diff/40001/chrome/browser/resources...
chrome/browser/resources/hotword/logging.js:20: DEBUG: DEBUG,
DEBUG: false,

[Anand Mistry (off Chromium), 2014-09-30 04:14:03]

Thanks for the reviews.

https://codereview.chromium.org/601123002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/hotword/logging.js (right):

https://codereview.chromium.org/601123002/diff/40001/chrome/browser/resources...
chrome/browser/resources/hotword/logging.js:8: var DEBUG = false;
On 2014/09/30 03:42:58, Dan Beam wrote:
> nit: just remove this

Done.

https://codereview.chromium.org/601123002/diff/40001/chrome/browser/resources...
chrome/browser/resources/hotword/logging.js:20: DEBUG: DEBUG,
On 2014/09/30 03:42:58, Dan Beam wrote:
> DEBUG: false,

Done.

[Anand Mistry (off Chromium), 2014-09-30 04:14:11]

The CQ bit was checked by amistry@chromium.org

[commit-bot: I haz the power, 2014-09-30 04:22:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/601123002/60001

[commit-bot: I haz the power, 2014-09-30 05:09:52]

Committed patchset #4 (id:60001) as 3ed359ca5e16c948d1b92c07fa8f11239c1da57a

[commit-bot: I haz the power, 2014-09-30 05:10:31]

Patchset 4 (id:??) landed as
https://crrev.com/31eb32766f8f1adfd7bd5f8a060b3795541fad59
Cr-Commit-Position: refs/heads/master@{#297366}