Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 601113002: RenderGrid::paintChild() declared but not defined. (Closed)

Created:
6 years, 2 months ago by mstensho (USE GERRIT)
Modified:
6 years, 2 months ago
Reviewers:
chrishtr, rune
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, jfernandez, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, Manuel Rego, rune+blink, svillar, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

RenderGrid::paintChild() declared but not defined. https://codereview.chromium.org/594293002/ moved paint code from RenderGrid to GridPainter, including the implementation of paintChild(), but the declaration was left behind in RenderGrid. R=chrishtr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182745

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/core/rendering/RenderGrid.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
mstensho (USE GERRIT)
6 years, 2 months ago (2014-09-25 06:47:50 UTC) #1
rune
lgtm
6 years, 2 months ago (2014-09-25 08:21:02 UTC) #3
chrishtr
lgtm
6 years, 2 months ago (2014-09-25 16:24:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601113002/1
6 years, 2 months ago (2014-09-25 16:25:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/28818)
6 years, 2 months ago (2014-09-25 18:23:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601113002/1
6 years, 2 months ago (2014-09-26 08:30:45 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 09:21:54 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182745

Powered by Google App Engine
This is Rietveld 408576698